linux-kernel - Re: [PATCH RFC net-next] net: Add dev_getbyhwaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250210-furry-toad-of-satiation-fce507@leitao>
Date: Mon, 10 Feb 2025 03:40:24 -0800
From: Breno Leitao <leitao@...ian.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, kernel-team@...a.com, kuniyu@...zon.com,
	ushankar@...estorage.com
Subject: Re: [PATCH RFC net-next] net: Add dev_getbyhwaddr_rtnl() helper

Hello Jakub,

On Fri, Feb 07, 2025 at 04:27:18PM -0800, Jakub Kicinski wrote:
> On Fri, 07 Feb 2025 04:11:34 -0800 Breno Leitao wrote:
> > +static bool dev_comp_addr(struct net_device *dev,
> > +			  unsigned short type,
> > +			  const char *ha)

> static bool dev_comp_addr(struct net_device *dev, unsigned short type,
> 			  const char *ha)

This one aligns better with the other functions in the file. Example:

  struct net_device *dev_getbyhwaddr_rcu(struct net *net, unsigned short type,
                                         const char *ha)

> > + */
> > +struct net_device *dev_getbyhwaddr_rtnl(struct net *net, unsigned short type,
> > +					const char *ha)
> 
> You missed adding this to a header file?

Yes. NIPA caught this one beautifully:

	https://patchwork.kernel.org/project/netdevbpf/patch/20250207-arm_fix_selftest-v1-1-487518d2fd1c@debian.org/

I will send a v2 soon,

Thanks for the review
--breno