linux-kernel - [PATCH] LoongArch: csum: Fix OoB access in IP checksum code for negative lengths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <D4E490BD8F1E672B+20250210114543.1090146-1-wangyuli@uniontech.com>
Date: Mon, 10 Feb 2025 19:45:43 +0800
From: WangYuli <wangyuli@...ontech.com>
To: chenhuacai@...nel.org,
	kernel@...0n.name,
	wangyuli@...ontech.com,
	guanwentao@...ontech.com
Cc: loongarch@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	maobibo@...ngson.cn,
	zhanjun@...ontech.com,
	chenlinxuan@...ontech.com
Subject: [PATCH] LoongArch: csum: Fix OoB access in IP checksum code for negative lengths

Commit 69e3a6aa6be2 ("LoongArch: Add checksum optimization for
64-bit system") would cause an undefined shift and an out-of-bounds
read.

Commit 8bd795fedb84 ("arm64: csum: Fix OoB access in IP checksum
code for negative lengths") fixes the same issue on ARM64.

Fixes: 69e3a6aa6be2 ("LoongArch: Add checksum optimization for 64-bit system")
Co-developed-by: Wentao Guan <guanwentao@...ontech.com>
Signed-off-by: Wentao Guan <guanwentao@...ontech.com>
Signed-off-by: Yuli Wang <wangyuli@...ontech.com>
---
 arch/loongarch/lib/csum.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/loongarch/lib/csum.c b/arch/loongarch/lib/csum.c
index a5e84b403c3b..df309ae4045d 100644
--- a/arch/loongarch/lib/csum.c
+++ b/arch/loongarch/lib/csum.c
@@ -25,7 +25,7 @@ unsigned int __no_sanitize_address do_csum(const unsigned char *buff, int len)
 	const u64 *ptr;
 	u64 data, sum64 = 0;
 
-	if (unlikely(len == 0))
+	if (unlikely(len <= 0))
 		return 0;
 
 	offset = (unsigned long)buff & 7;
-- 
2.47.2