linux-kernel - Re: [PATCH] Staging: nvec: Fix pm_power_off reset condition in tegra_nvec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502102056.z2poG8tW-lkp@intel.com>
Date: Mon, 10 Feb 2025 20:31:43 +0800
From: kernel test robot <lkp@...el.com>
To: Dima Volkovsk <s0ldw3ll@...il.com>, marvin24@....de,
	gregkh@...uxfoundation.org, ac100@...ts.launchpad.net,
	linux-tegra@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Dima Volkovsk <s0ldw3ll@...il.com>
Subject: Re: [PATCH] Staging: nvec: Fix pm_power_off reset condition in
 tegra_nvec_remove

Hi Dima,

kernel test robot noticed the following build warnings:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Dima-Volkovsk/Staging-nvec-Fix-pm_power_off-reset-condition-in-tegra_nvec_remove/20250210-041929
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20250209201752.66313-1-s0ldw3ll%40gmail.com
patch subject: [PATCH] Staging: nvec: Fix pm_power_off reset condition in tegra_nvec_remove
config: arm-defconfig (https://download.01.org/0day-ci/archive/20250210/202502102056.z2poG8tW-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 6807164500e9920638e2ab0cdb4bf8321d24f8eb)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250210/202502102056.z2poG8tW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502102056.z2poG8tW-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/staging/nvec/nvec.c:908:19: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
     908 |         if (pm_power_off = nvec_power_off)
         |             ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
   drivers/staging/nvec/nvec.c:908:19: note: place parentheses around the assignment to silence this warning
     908 |         if (pm_power_off = nvec_power_off)
         |                          ^               
         |             (                            )
   drivers/staging/nvec/nvec.c:908:19: note: use '==' to turn this assignment into an equality comparison
     908 |         if (pm_power_off = nvec_power_off)
         |                          ^
         |                          ==
   1 warning generated.


vim +908 drivers/staging/nvec/nvec.c

   896	
   897	static void tegra_nvec_remove(struct platform_device *pdev)
   898	{
   899		struct nvec_chip *nvec = platform_get_drvdata(pdev);
   900	
   901		nvec_toggle_global_events(nvec, false);
   902		mfd_remove_devices(nvec->dev);
   903		nvec_unregister_notifier(nvec, &nvec->nvec_status_notifier);
   904		cancel_work_sync(&nvec->rx_work);
   905		cancel_work_sync(&nvec->tx_work);
   906	
   907		/* only reset pm_power_off if it's our handler */
 > 908		if (pm_power_off = nvec_power_off)
   909			pm_power_off = NULL;
   910	}
   911	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki