linux-kernel - Re: [PATCH v2 16/18] cxl/region: Show message on broken target list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6nyfPERAmNb9jFr@rric.localdomain>
Date: Mon, 10 Feb 2025 13:35:08 +0100
From: Robert Richter <rrichter@....com>
To: Alison Schofield <alison.schofield@...el.com>
Cc: Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Davidlohr Bueso <dave@...olabs.net>, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org, Gregory Price <gourry@...rry.net>,
	"Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>,
	Terry Bowman <terry.bowman@....com>
Subject: Re: [PATCH v2 16/18] cxl/region: Show message on broken target list

On 07.02.25 15:36:45, Alison Schofield wrote:
> On Fri, Feb 07, 2025 at 04:37:51PM +0100, Robert Richter wrote:
> > Broken target lists are hard to discover as the driver fails at a
> > later initialization stage. Add an error message for this.
> 
> Hi Richard - There's 3 of these patches in a row, so I'll share
> the common ask here. How about replacing vague 'Show message'
> with type of message like "Add [dev_dbg() | dev_warn() | dev_err()]...
> I think there is one of each flavor.
> 
> For this one, are you able to append here what it looks like
> when there is a broken target list during region creation.
> ie...put in context how this message fits into the full spew.

Yes, will updated the patch descriptions.

-Robert