linux-kernel - Re: [PATCH v3 05/28] mm/hugetlb: fix round-robin bootmem allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6n30QhWeAyFea40@localhost.localdomain>
Date: Mon, 10 Feb 2025 13:57:53 +0100
From: Oscar Salvador <osalvador@...e.de>
To: Frank van der Linden <fvdl@...gle.com>
Cc: akpm@...ux-foundation.org, muchun.song@...ux.dev, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, yuzhao@...gle.com,
	usamaarif642@...il.com, joao.m.martins@...cle.com,
	roman.gushchin@...ux.dev, Zhenguo Yao <yaozhenguo1@...il.com>
Subject: Re: [PATCH v3 05/28] mm/hugetlb: fix round-robin bootmem allocation

On Thu, Feb 06, 2025 at 06:50:45PM +0000, Frank van der Linden wrote:
> Commit b5389086ad7b ("hugetlbfs: extend the definition of hugepages parameter to support node allocation")
> changed the NUMA_NO_NODE round-robin allocation behavior in case of a
> failure to allocate from one NUMA node. The code originally moved on to
> the next node to try again, but now it immediately breaks out of the loop.
> 
> Restore the original behavior.

Did you stumble upon this?

AFAICS, memblock_alloc_range_nid() will call memblock_find_in_range_node() with
NUMA_NO_NODE for exact_nide = false, which would be our case.
Meaning that if memblock_alloc_try_nid_raw() returns false here, it is because
we could not allocate the page in any node, right?


-- 
Oscar Salvador
SUSE Labs