linux-kernel - Re: [RESEND PATCH] sctp: Remove commented out code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6n8LhxIIctmrbo8@t14s.localdomain>
Date: Mon, 10 Feb 2025 10:16:30 -0300
From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Xin Long <lucien.xin@...il.com>, linux-sctp@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] sctp: Remove commented out code

On Mon, Feb 10, 2025 at 02:07:18PM +0100, Thorsten Blum wrote:
> On 10. Feb 2025, at 13:51, Marcelo Ricardo Leitner wrote:
> > On Sun, Feb 09, 2025 at 10:00:24PM +0100, Thorsten Blum wrote:
> >> Remove commented out code.
> >> 
> >> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> > 
> > SCTP patches are picked up on the generic networking mailing list.
> > You need to send this patch towards netdev@...r.kernel.org.
> > Thanks for your patch, but please post it over there.
> 
> Hm, the get_maintainer script doesn't mention netdev@...r.kernel.org
> 
> $ ./scripts/get_maintainer.pl -f include/linux/sctp.h
> Marcelo Ricardo Leitner <marcelo.leitner@...il.com> (maintainer:SCTP PROTOCOL)
> Xin Long <lucien.xin@...il.com> (maintainer:SCTP PROTOCOL)
> linux-sctp@...r.kernel.org (open list:SCTP PROTOCOL)
> linux-kernel@...r.kernel.org (open list)
> 
> Should this be fixed?

Yes. I'll send a patch for it. I believe the changes below are what is
needed.

$ ./scripts/get_maintainer.pl -f include/linux/sctp.h
Marcelo Ricardo Leitner <marcelo.leitner@...il.com> (maintainer:SCTP PROTOCOL)
Xin Long <lucien.xin@...il.com> (maintainer:SCTP PROTOCOL)
"David S. Miller" <davem@...emloft.net> (maintainer:NETWORKING [GENERAL])
Eric Dumazet <edumazet@...gle.com> (maintainer:NETWORKING [GENERAL])
Jakub Kicinski <kuba@...nel.org> (maintainer:NETWORKING [GENERAL])
Paolo Abeni <pabeni@...hat.com> (maintainer:NETWORKING [GENERAL])
linux-sctp@...r.kernel.org (open list:SCTP PROTOCOL)
netdev@...r.kernel.org (open list:NETWORKING [GENERAL])
linux-kernel@...r.kernel.org (open list)

Thanks,
Marcelo

---8<---
diff --git a/MAINTAINERS b/MAINTAINERS
index 560a65b85297..eee8d442a4eb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16182,6 +16182,7 @@ F:	include/linux/netdev*
 F:	include/linux/netlink.h
 F:	include/linux/netpoll.h
 F:	include/linux/rtnetlink.h
+F:	include/linux/sctp.h
 F:	include/linux/seq_file_net.h
 F:	include/linux/skbuff*
 F:	include/net/
@@ -16197,6 +16198,7 @@ F:	include/uapi/linux/netdev*
 F:	include/uapi/linux/netlink.h
 F:	include/uapi/linux/netlink_diag.h
 F:	include/uapi/linux/rtnetlink.h
+F:	include/uapi/linux/sctp.h
 F:	lib/net_utils.c
 F:	lib/random32.c
 F:	net/