linux-kernel - Re: "netfs: Can't donate prior to front"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3052002.1739196466@warthog.procyon.org.uk>
Date: Mon, 10 Feb 2025 14:07:46 +0000
From: David Howells <dhowells@...hat.com>
To: Max Kellermann <max.kellermann@...os.com>
Cc: dhowells@...hat.com, netfs@...ts.linux.dev,
    LKML <linux-kernel@...r.kernel.org>, linux-nfs@...r.kernel.org
Subject: Re: "netfs: Can't donate prior to front"

Can you apply the attached patch to your kernel, and then run with:

   echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_read/enable
   echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_rreq/enable
   echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_sreq/enable
   echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_failure/enable
   echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_donate/enable
   echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_progress/enable

enabled.  If you can capture the trace output (and compress it!), that should
hopefully help debug this.

David

diff --git a/fs/netfs/read_collect.c b/fs/netfs/read_collect.c
index e8624f5c7fcc..8b78c1ec0677 100644
--- a/fs/netfs/read_collect.c
+++ b/fs/netfs/read_collect.c
@@ -312,6 +312,7 @@ static bool netfs_consume_read_data(struct netfs_io_subrequest *subreq, bool was
 	printk("folio: %llx-%llx\n", fpos, fend - 1);
 	printk("donated: prev=%zx next=%zx\n", prev_donated, next_donated);
 	printk("s=%llx av=%zx part=%zx\n", start, avail, part);
+	tracing_off();
 	BUG();
 }