linux-kernel - Re: [PATCH v2 2/2] tools: Remove redundant quiet setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <21f98687-f715-449c-86f0-c095ea499450@kernel.org>
Date: Tue, 11 Feb 2025 00:00:49 +0000
From: Quentin Monnet <qmo@...nel.org>
To: Charlie Jenkins <charlie@...osinc.com>,
 Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
 Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau
 <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>,
 Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
 Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>,
 Lukasz Luba <lukasz.luba@....com>, Josh Poimboeuf <jpoimboe@...nel.org>,
 Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>,
 Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
 Steven Rostedt <rostedt@...dmis.org>
Cc: bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-perf-users@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-input@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] tools: Remove redundant quiet setup

2025-02-10 10:34 UTC-0800 ~ Charlie Jenkins <charlie@...osinc.com>
> Q is exported from Makefile.include so it is not necessary to manually
> set it.
> 
> Signed-off-by: Charlie Jenkins <charlie@...osinc.com>
> ---
>  tools/arch/arm64/tools/Makefile           |  6 ------
>  tools/bpf/Makefile                        |  6 ------
>  tools/bpf/bpftool/Documentation/Makefile  |  6 ------
>  tools/bpf/bpftool/Makefile                |  6 ------
>  tools/bpf/resolve_btfids/Makefile         |  2 --
>  tools/bpf/runqslower/Makefile             |  5 +----
>  tools/lib/bpf/Makefile                    | 13 -------------
>  tools/lib/perf/Makefile                   | 13 -------------
>  tools/lib/thermal/Makefile                | 13 -------------
>  tools/objtool/Makefile                    |  6 ------
>  tools/testing/selftests/bpf/Makefile.docs |  6 ------
>  tools/testing/selftests/hid/Makefile      |  2 --
>  tools/thermal/lib/Makefile                | 13 -------------
>  tools/tracing/latency/Makefile            |  6 ------
>  tools/tracing/rtla/Makefile               |  6 ------
>  tools/verification/rv/Makefile            |  6 ------
>  16 files changed, 1 insertion(+), 114 deletions(-)
> 

[...]

> diff --git a/tools/bpf/bpftool/Documentation/Makefile b/tools/bpf/bpftool/Documentation/Makefile
> index 4315652678b9f2e27e48b7815f3b9ddc70a57165..bf843f328812e10dd65a73f355f74e6825ad95b9 100644
> --- a/tools/bpf/bpftool/Documentation/Makefile
> +++ b/tools/bpf/bpftool/Documentation/Makefile
> @@ -5,12 +5,6 @@ INSTALL ?= install
>  RM ?= rm -f
>  RMDIR ?= rmdir --ignore-fail-on-non-empty
>  
> -ifeq ($(V),1)
> -  Q =
> -else
> -  Q = @
> -endif
> -
>  prefix ?= /usr/local
>  mandir ?= $(prefix)/man
>  man8dir = $(mandir)/man8
> diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
> index dd9f3ec842017f1dd24054bf3a0986d546811dc4..6ea4823b770cbbe7fd9eb7da79956cc1dae1f204 100644
> --- a/tools/bpf/bpftool/Makefile
> +++ b/tools/bpf/bpftool/Makefile
> @@ -7,12 +7,6 @@ srctree := $(patsubst %/,%,$(dir $(srctree)))
>  srctree := $(patsubst %/,%,$(dir $(srctree)))
>  endif
>  
> -ifeq ($(V),1)
> -  Q =
> -else
> -  Q = @
> -endif
> -
>  BPF_DIR = $(srctree)/tools/lib/bpf
>  
>  ifneq ($(OUTPUT),)

This is OK from bpftool's side, the GitHub mirror has a Makefile.include
included from both main and doc Makefiles, and where I can move this
definition.

Acked-by: Quentin Monnet <qmo@...nel.org>

Thanks