linux-kernel - Re: [PATCH v3] of: property: Increase NR_FWNODE_REFERENCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73eb84f3-8b9d-41f4-9b59-d059111a3d03@icloud.com>
Date: Tue, 11 Feb 2025 20:20:03 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, "Rob Herring (Arm)"
 <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>,
 Len Brown <lenb@...nel.org>, Daniel Scally <djrscally@...il.com>,
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>, linux-acpi@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v3] of: property: Increase NR_FWNODE_REFERENCE_ARGS

On 2025/2/10 23:34, Andy Shevchenko wrote:
>> It may cause firmware node reference's argument count out of range if
>> directly assign DT node reference's argument count to firmware's.
>>
>> drivers/of/property.c:of_fwnode_get_reference_args() is doing the direct
>> assignment, so may cause firmware's argument count @args->nargs got out
>> of range, namely, in [9, 16].
>>
>> Fix by increasing NR_FWNODE_REFERENCE_ARGS to 16 to meet DT requirement.
> ...
> 
>> -#define NR_FWNODE_REFERENCE_ARGS	8
>> +#define NR_FWNODE_REFERENCE_ARGS	16
> Thinking of the case, perhaps you also want
> 
> static_assert(NR_FWNODE_REFERENCE_ARGS == MAX_PHANDLE_ARGS);
> 
> to be put somewhere, but I don't think we can do it in this header file.

thank you Andy for code review.

yes. it seems there are good location to place the static_assert().

is it okay to associate two macros by
#define MAX_PHANDLE_ARGS NR_FWNODE_REFERENCE_ARGS
OR
replace all MAX_PHANDLE_ARGS instances with NR_FWNODE_REFERENCE_ARGS
?