linux-kernel - Re: [PATCH v4 6/8] scsi: ufs: core: Check if scaling up is required when disable clkscale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34a7946c01e263c57738a9dbcce0d672c7acea0c.camel@mediatek.com>
Date: Tue, 11 Feb 2025 12:58:36 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "beanhuo@...ron.com" <beanhuo@...ron.com>, "avri.altman@....com"
	<avri.altman@....com>, "quic_rampraka@...cinc.com"
	<quic_rampraka@...cinc.com>, "quic_cang@...cinc.com" <quic_cang@...cinc.com>,
	"quic_nguyenb@...cinc.com" <quic_nguyenb@...cinc.com>,
	"quic_nitirawa@...cinc.com" <quic_nitirawa@...cinc.com>, "bvanassche@....org"
	<bvanassche@....org>, "quic_ziqichen@...cinc.com"
	<quic_ziqichen@...cinc.com>, "junwoo80.lee@...sung.com"
	<junwoo80.lee@...sung.com>, "mani@...nel.org" <mani@...nel.org>,
	"martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC: "ahalaney@...hat.com" <ahalaney@...hat.com>, "neil.armstrong@...aro.org"
	<neil.armstrong@...aro.org>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "manivannan.sadhasivam@...aro.org"
	<manivannan.sadhasivam@...aro.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "linux-arm-msm@...r.kernel.org"
	<linux-arm-msm@...r.kernel.org>, "James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>
Subject: Re: [PATCH v4 6/8] scsi: ufs: core: Check if scaling up is required
 when disable clkscale

On Mon, 2025-02-10 at 18:02 +0800, Ziqi Chen wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> When disabling clkscale via the clkscale_enable sysfs entry, UFS
> driver
> shall perform scaling up once regardless. Check if scaling up is
> required
> or not first to avoid repetitive work.
> 
> Co-developed-by: Can Guo <quic_cang@...cinc.com>
> Signed-off-by: Can Guo <quic_cang@...cinc.com>
> Signed-off-by: Ziqi Chen <quic_ziqichen@...cinc.com>
> Reviewed-by: Bart Van Assche <bvanassche@....org>
> Tested-by: Neil Armstrong <neil.armstrong@...aro.org>
> ---
>  drivers/ufs/core/ufshcd.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index ebab897080a6..bd93119a177d 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -1777,6 +1777,10 @@ static ssize_t
> ufshcd_clkscale_enable_store(struct device *dev,
>         freq = clki->max_freq;
> 
>         ufshcd_suspend_clkscaling(hba);
> +
> +       if (!ufshcd_is_devfreq_scaling_required(hba, freq, true))
> +               goto out_rel;
> +
>         err = ufshcd_devfreq_scale(hba, freq, true);
>         if (err)
>                 dev_err(hba->dev, "%s: failed to scale clocks up
> %d\n",
> --
> 2.34.1
> 

Reviewed-by: Peter Wang <peter.wang@...iatek.com>