linux-kernel - Re: [RESEND PATCH v2] params: Annotate struct module_param_attrs with __counted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <EF59E5FB-5998-4BD8-9E51-6B52198638CA@linux.dev>
Date: Tue, 11 Feb 2025 14:18:08 +0100
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Luis Chamberlain <mcgrof@...nel.org>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Nathan Chancellor <nathan@...nel.org>,
 Kees Cook <kees@...nel.org>,
 linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org,
 "Gustavo A. R. Silva" <gustavoars@...nel.org>
Subject: Re: [RESEND PATCH v2] params: Annotate struct module_param_attrs with
 __counted_by()

On 4. Feb 2025, at 17:44, Thorsten Blum wrote:
> On 14. Jan 2025, at 22:49, Thorsten Blum wrote:
>> Add the __counted_by compiler attribute to the flexible array member
>> attrs to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
>> CONFIG_FORTIFY_SOURCE.
>> 
>> Increment num before adding a new param_attribute to the attrs array and
>> adjust the array index accordingly. Increment num immediately after the
>> first reallocation such that the reallocation for the NULL terminator
>> only needs to add 1 (instead of 2) to mk->mp->num.
>> 
>> Use struct_size() instead of manually calculating the size for the
>> reallocation.
>> 
>> Use krealloc_array() for the additional NULL terminator.
> 
> Hi, could someone please take another look at this?
> 
> It was already applied to modules-next in August 2024, but dropped
> shortly after because of a Clang issue:
> 
> https://lore.kernel.org/all/20241029140036.577804-1-kernel@jfarr.cc
> 
> The Clang issue has been fixed for a while and this patch could be
> applied again.

Hi Luis,

you already applied this to modules-next in September of last year [1].
Could you apply it again now that the Clang issue has been fixed?

Thanks,
Thorsten

[1] https://lore.kernel.org/linux-kernel/ZuHaiiMV6ESS8p7z@bombadil.infradead.org/