linux-kernel - Re: [PATCH v4 2/2] mfd: cgbc: add a hwmon cell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250211133955.GR1868108@google.com>
Date: Tue, 11 Feb 2025 13:39:55 +0000
From: Lee Jones <lee@...nel.org>
To: Thomas Richard <thomas.richard@...tlin.com>
Cc: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
	Jonathan Corbet <corbet@....net>, linux-kernel@...r.kernel.org,
	linux-hwmon@...r.kernel.org, thomas.petazzoni@...tlin.com,
	blake.vermeer@...sight.com, linux-doc@...r.kernel.org
Subject: Re: [PATCH v4 2/2] mfd: cgbc: add a hwmon cell

If you resubmit this set, please capitalise the first char in the
subject line after the driver identifiers.

> The Board Controller has some internal sensors.
> Add a hwmon cell for the cgbc-hwmon driver which adds support for
> temperature, voltage, current and fan sensors.

Generally fine.

Line-breaking just for a new sentence is an odd choice though.

> Signed-off-by: Thomas Richard <thomas.richard@...tlin.com>
> ---
>  drivers/mfd/cgbc-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/cgbc-core.c b/drivers/mfd/cgbc-core.c
> index 85283c8dde25..0460e4e3f3c5 100644
> --- a/drivers/mfd/cgbc-core.c
> +++ b/drivers/mfd/cgbc-core.c
> @@ -236,6 +236,7 @@ static struct mfd_cell cgbc_devs[] = {
>  	{ .name = "cgbc-gpio"	},
>  	{ .name = "cgbc-i2c", .id = 1 },
>  	{ .name = "cgbc-i2c", .id = 2 },
> +	{ .name = "cgbc-hwmon"	},
>  };
>  
>  static int cgbc_map(struct cgbc_device_data *cgbc)
> 
> -- 
> 2.39.5
> 

-- 
Lee Jones [李琼斯]