linux-kernel - Re: [PATCH v4] drm/sched: Use struct for drm_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6tmyHpqnpkP2gKq@pollux>
Date: Tue, 11 Feb 2025 16:03:36 +0100
From: Danilo Krummrich <dakr@...hat.com>
To: Philipp Stanner <phasta@...nel.org>
Cc: Min Ma <min.ma@....com>, Lizhi Hou <lizhi.hou@....com>,
	Oded Gabbay <ogabbay@...nel.org>,
	Alex Deucher <alexander.deucher@....com>,
	Christian König <christian.koenig@....com>,
	Xinhui Pan <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>,
	Lucas Stach <l.stach@...gutronix.de>,
	Russell King <linux+etnaviv@...linux.org.uk>,
	Christian Gmeiner <christian.gmeiner@...il.com>,
	Frank Binns <frank.binns@...tec.com>,
	Matt Coster <matt.coster@...tec.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Qiang Yu <yuq825@...il.com>, Rob Clark <robdclark@...il.com>,
	Sean Paul <sean@...rly.run>, Konrad Dybcio <konradybcio@...nel.org>,
	Abhinav Kumar <quic_abhinavk@...cinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	Marijn Suijten <marijn.suijten@...ainline.org>,
	Karol Herbst <kherbst@...hat.com>, Lyude Paul <lyude@...hat.com>,
	Boris Brezillon <boris.brezillon@...labora.com>,
	Rob Herring <robh@...nel.org>, Steven Price <steven.price@....com>,
	Liviu Dudau <liviu.dudau@....com>,
	Matthew Brost <matthew.brost@...el.com>,
	Melissa Wen <mwen@...lia.com>,
	Maíra Canal <mcanal@...lia.com>,
	Lucas De Marchi <lucas.demarchi@...el.com>,
	Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Sunil Khatri <sunil.khatri@....com>,
	Lijo Lazar <lijo.lazar@....com>,
	Hawking Zhang <Hawking.Zhang@....com>,
	Mario Limonciello <mario.limonciello@....com>,
	Ma Jun <Jun.Ma2@....com>, Yunxiang Li <Yunxiang.Li@....com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	amd-gfx@...ts.freedesktop.org, etnaviv@...ts.freedesktop.org,
	lima@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org,
	freedreno@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
	intel-xe@...ts.freedesktop.org,
	Christian Gmeiner <cgmeiner@...lia.com>,
	Tvrtko Ursulin <tvrtko.ursulin@...lia.com>
Subject: Re: [PATCH v4] drm/sched: Use struct for drm_sched_init() params

On Tue, Feb 11, 2025 at 12:14:23PM +0100, Philipp Stanner wrote:
> drm_sched_init() has a great many parameters and upcoming new
> functionality for the scheduler might add even more. Generally, the
> great number of parameters reduces readability and has already caused
> one missnaming, addressed in:
> 
> commit 6f1cacf4eba7 ("drm/nouveau: Improve variable name in
> nouveau_sched_init()").
> 
> Introduce a new struct for the scheduler init parameters and port all
> users.
> 
> Signed-off-by: Philipp Stanner <phasta@...nel.org>
> Reviewed-by: Liviu Dudau <liviu.dudau@....com>
> Acked-by: Matthew Brost <matthew.brost@...el.com> # for Xe
> Reviewed-by: Boris Brezillon <boris.brezillon@...labora.com> # for Panfrost and Panthor
> Reviewed-by: Christian Gmeiner <cgmeiner@...lia.com> # for Etnaviv
> Reviewed-by: Frank Binns <frank.binns@...tec.com> # for Imagination
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@...lia.com> # for Sched
> Reviewed-by: Maíra Canal <mcanal@...lia.com> # for v3d

Reviewed-by: Danilo Krummrich <dakr@...nel.org>