linux-kernel - Re: [PATCH next 2/3] dt-bindings: usb: microchip,usb2514: add support for USB2512/USB2513

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250211-endorphin-harmony-f8d7c8ac9953@spud>
Date: Tue, 11 Feb 2025 16:44:30 +0000
From: Conor Dooley <conor@...nel.org>
To: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
Cc: gregkh@...uxfoundation.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, festevam@...il.com, linux-usb@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	m.felsch@...gutronix.de, bsp-development.geo@...ca-geosystems.com
Subject: Re: [PATCH next 2/3] dt-bindings: usb: microchip,usb2514: add
 support for USB2512/USB2513

On Tue, Feb 11, 2025 at 11:58:38AM +0100, Catalin Popescu wrote:
> Extend support to Microchip hubs USB2512 & USB2513 which are identical
> to USB2514 but offer less downstream ports (i.e. respectively 2 and 3
> ports).
> 
> Signed-off-by: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
> ---
>  .../bindings/usb/microchip,usb2514.yaml         | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> index 743f7a22f13d..d159cde04c84 100644
> --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml
> @@ -14,11 +14,18 @@ allOf:
>  
>  properties:
>    compatible:
> -    enum:
> -      - usb424,2412
> -      - usb424,2417
> -      - usb424,2514
> -      - usb424,2517
> +    oneOf:
> +      - items:

This items isn't doing anything, as it only has one entry (the enum).

> +          - enum:
> +              - usb424,2412
> +              - usb424,2417
> +              - usb424,2514
> +              - usb424,2517
> +      - items:
> +          - enum:
> +              - usb424,2512
> +              - usb424,2513
> +          - const: usb424,2514
>  
>    reg: true
>  
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)