linux-kernel - Re: [PATCH v10 00/14] platform/x86: alienware-wmi driver rework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D7PTGS79ZMT6.WRYZ7J20YSDU@gmail.com>
Date: Tue, 11 Feb 2025 13:09:45 -0500
From: "Kurt Borja" <kuurtb@...il.com>
To: "Andy Shevchenko" <andriy.shevchenko@...el.com>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 <platform-driver-x86@...r.kernel.org>, "Armin Wolf" <W_Armin@....de>,
 "Mario Limonciello" <mario.limonciello@....com>, "Hans de Goede"
 <hdegoede@...hat.com>, <Dell.Client.Kernel@...l.com>, "LKML"
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 00/14] platform/x86: alienware-wmi driver rework

Hi all,

On Tue Feb 11, 2025 at 11:58 AM -05, Andy Shevchenko wrote:
> On Mon, Feb 10, 2025 at 08:48:05AM -0500, Kurt Borja wrote:
>> On Mon Feb 10, 2025 at 6:53 AM -05, Ilpo Järvinen wrote:
>> > On Fri, 7 Feb 2025, Kurt Borja wrote:
>> >
>> >> One more correction. I apologize for the noise!
>> >
>> > Applied to review-ilpo-next. Thanks.
>> 
>> Thank you so much for reviewing this, Ilpo :) 
>
> Please address my concerns in the followup patches.
>
> (Main concern is abuse of objs, others are more like cleanups to improve
>  readability and maintenance)

I agree with most of your coments. Some require additional patches tho,
which is fine but are outside the scope of this series. I still have a
lot of doubts about how to proceed with the Makefile stuff, I don't
understand the root of the problem and a lot of drivers already do this
so I'm a bit confused.

Ilpo, how should we proceed here? I see this series has not hit
linux-next so, is it fine to send a v11 incorporating Andy's comments?
Obviously after understanding the Makefile problems.

Also with all this fixes problems I'm having seconds thoughts about
splitting the file (patch 11). I'd also like to know your opinion on
that, Ilpo.

Thank you again for your review Andy!

-- 
 ~ Kurt