linux-kernel - Re: [PATCH 3/5] iommu/dart: Set DMA domain for locked DARTs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d6b3fe7-9376-422b-a2e6-ebaed7b6cd75@arm.com>
Date: Tue, 11 Feb 2025 18:25:35 +0000
From: Robin Murphy <robin.murphy@....com>
To: Alyssa Rosenzweig <alyssa@...enzweig.io>, Sven Peter
 <sven@...npeter.dev>, Janne Grunau <j@...nau.net>,
 Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>
Cc: asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 iommu@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] iommu/dart: Set DMA domain for locked DARTs

On 2025-02-10 7:39 pm, Alyssa Rosenzweig wrote:
> This is required.

Now that we can, I'd really rather do this properly and not offer an 
identity domain in the first place when it's not available.

Thanks,
Robin.

> Signed-off-by: Alyssa Rosenzweig <alyssa@...enzweig.io>
> ---
>   drivers/iommu/apple-dart.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
> index 9c74a95eb7e819e94ab2fb47ed0d411a1eba8bf7..9c6f780dc7220096ed6bba692fa1a4bd859b0d61 100644
> --- a/drivers/iommu/apple-dart.c
> +++ b/drivers/iommu/apple-dart.c
> @@ -941,6 +941,8 @@ static int apple_dart_def_domain_type(struct device *dev)
>   		return IOMMU_DOMAIN_IDENTITY;
>   	if (!cfg->stream_maps[0].dart->supports_bypass)
>   		return IOMMU_DOMAIN_DMA;
> +	if (cfg->stream_maps[0].dart->locked)
> +		return IOMMU_DOMAIN_DMA;
>   
>   	return 0;
>   }
>