linux-kernel - Re: [PATCH 2/5] iommu/dart: Skip reset for locked DARTs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6uao2OnBcg9zkrc@blossom>
Date: Tue, 11 Feb 2025 13:44:51 -0500
From: Alyssa Rosenzweig <alyssa@...enzweig.io>
To: Robin Murphy <robin.murphy@....com>
Cc: Sven Peter <sven@...npeter.dev>, Janne Grunau <j@...nau.net>,
	Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
	asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	iommu@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Hector Martin <marcan@...can.st>
Subject: Re: [PATCH 2/5] iommu/dart: Skip reset for locked DARTs

> >   	struct apple_dart *dart = platform_get_drvdata(pdev);
> > -	apple_dart_hw_reset(dart);
> > +	if (!dart->locked)
> > +		apple_dart_hw_reset(dart);
> 
> Not much point saving anything on suspend either, in that case.

Quite right. Fixed in v2, thanks!