linux-kernel - Re: [PATCH] dt-bindings: leds: Allow differently named multicolor leds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de7fb605-527e-4c62-9b5d-947a1636c54b@kernel.org>
Date: Tue, 11 Feb 2025 20:10:28 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: J. Neuschäfer <j.ne@...teo.net>,
 Lee Jones <lee@...nel.org>
Cc: Pavel Machek <pavel@....cz>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Andrew Davis <afd@...com>,
 linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: Allow differently named multicolor
 leds

On 11/02/2025 19:50, J. Neuschäfer wrote:
> On Tue, Feb 11, 2025 at 02:43:00PM +0000, Lee Jones wrote:
>> On Sun, 09 Feb 2025, J. Neuschäfer via B4 Relay wrote:
>>
>>> From: "J. Neuschäfer" <j.ne@...teo.net>
>>>
>>> In some cases, a board may have multiple multi-leds, which can't be
>>> distinguished by unit address. In such cases it should be possible to
>>> name them differently, for example multi-led-a and multi-led-b.
>>> This patch adds another node name pattern to leds-class-multicolor.yaml
>>> to allow such names.
>>
>> Which H/W needs this?  Is it upstream?  Where is the doc / usage?
> 
> I encountered this situation while upstreaming the LANCOM NWAPP2 board,
> which has multiple LED-group-based multicolor LEDs:
> 
>   https://lore.kernel.org/lkml/20250102-mpc83xx-v1-16-86f78ba2a7af@posteo.net/

Which LEDs are these? I don't see multi-led there node name at all.

This patch must come with user. It's fine to send the user separately,
but please provide lore link to exact user.

Otherwise what certainty we have that this change is needed in the first
place?

> 
> Since they are based on leds-group-multicolor, they don't have a unit
> address, but there is more than one on the same level (as direct
> sub-nodes of the DT root node).

Which binding is this?

Best regards,
Krzysztof