linux-kernel - Re: [PATCH v3] ACPI: platform-profile: Fix CFI violation when accessing sysfs files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250211191444.GC2995885@ax162>
Date: Tue, 11 Feb 2025 14:14:44 -0500
From: Nathan Chancellor <nathan@...nel.org>
To: Mark Pearson <mpearson-lenovo@...ebb.ca>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
	Hans de Goede <hdegoede@...hat.com>,
	"Limonciello, Mario" <mario.limonciello@....com>,
	Kees Cook <kees@...nel.org>,
	Sami Tolvanen <samitolvanen@...gle.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
	patches@...ts.linux.dev, stable@...r.kernel.org,
	John Rowley <lkml@...nrowley.me>
Subject: Re: [PATCH v3] ACPI: platform-profile: Fix CFI violation when
 accessing sysfs files

Hi Mark,

On Tue, Feb 11, 2025 at 10:05:18AM -0500, Mark Pearson wrote:
> Just a note to say thank you for noticing my email address change -
> the old lenovo one was awful to use so I dropped it a while back, but
> it meant I missed your first two patches (my mail filters for the list
> should have caught it and I'll have to figure out why not...)

No worries, I totally get that. It may be good to update the few places
in the kernel that still use your Lenovo address but I understand if
there are other reasons to keep it around. .mailmap could also help too.

> Patch looks fine (I'd like to try it out on my system - will aim to do
> that today). I didn't know what CFI was (and have lightly educated
> myself now).  Is there a better way to fix this so it's common across
> all drivers somehow? Updating every individual instance is going to be
> a lot.

This does not happen all too often as far as I can tell. I have only
sent a handful of these patches over the past couple of years since CFI
was officially merged. Due to the way these sysfs interfaces work, I am
not sure this can really be fixed at a grand scale.

Cheers,
Nathan