linux-kernel - Re: [PATCH] thermal/netlink: Prevent Userspace Segmentation Fault by Adjusting UAPI Header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jykaz8y9Wb3uT=jmtrf0Q3xxWYc5nxDH_KknvjFUjfJg@mail.gmail.com>
Date: Tue, 11 Feb 2025 20:56:09 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>
Cc: rafael.j.wysocki@...el.com, linux-kernel@...r.kernel.org, 
	linux-pm@...r.kernel.org, lukasz.luba@....com, srinivas.pandruvada@...el.com
Subject: Re: [PATCH] thermal/netlink: Prevent Userspace Segmentation Fault by
 Adjusting UAPI Header

On Tue, Feb 11, 2025 at 9:01 AM Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
>
> On 08/02/2025 08:49, Zhang Rui wrote:
> > The intel-lpmd tool [1], which uses the THERMAL_GENL_ATTR_CPU_CAPABILITY
> > attribute to receive HFI events from kernel space, encounters a
> > segmentation fault after commit 1773572863c4 ("thermal: netlink: Add the
> > commands and the events for the thresholds").
> >
> > The issue arises because the THERMAL_GENL_ATTR_CPU_CAPABILITY raw value
> > was changed while intel_lpmd still uses the old value.
> >
> > Although intel_lpmd can be updated to check the THERMAL_GENL_VERSION and
> > use the appropriate THERMAL_GENL_ATTR_CPU_CAPABILITY value, the commit
> > itself is questionable. The commit introduced a new element in the
> > middle of enum thermal_genl_attr, which affects many existing attributes
> > and introduces potential risks and unnecessary maintenance burdens for
> > userspace thermal netlink event users.
> >
> > Solve the issue by moving the newly introduced
> > THERMAL_GENL_ATTR_TZ_PREV_TEMP attribute to the end of the
> > enum thermal_genl_attr. This ensures that all existing thermal generic
> > netlink attributes remain unaffected.
> >
> > Link: https://github.com/intel/intel-lpmd [1]
> > Fixes: 1773572863c4 ("thermal: netlink: Add the commands and the events for the thresholds")
> > Signed-off-by: Zhang Rui <rui.zhang@...el.com>
> > ---
>
> Right, thanks for the fix
>
> Reviewed-by: Daniel Lezcano <daniel.lezcano@...aro.org>

Applied as 6.14-rc material, thanks!