[an error occurred while processing this directive]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

[an error occurred while processing this directive]

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3876702.kQq0lBPeGt@rjwysocki.net>
Date: Tue, 11 Feb 2025 22:03:56 +0100
From: "Rafael J. Wysocki" <rjw@...ysocki.net>
To: Linux PM <linux-pm@...r.kernel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Alan Stern <stern@...land.harvard.edu>, Ulf Hansson <ulf.hansson@...aro.org>,
 Johan Hovold <johan@...nel.org>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Jon Hunter <jonathanh@...dia.com>
Subject:
 [PATCH v1 02/10] PM: sleep: core: Use pm_runtime_no_support() during
 set_active updates

From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

It is pointless to set power.set_active for devices that have never had
runtime PM enabled, so don't do that.

Fixes: 7585946243d6 ("PM: sleep: core: Restrict power.set_active propagation")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
---
 drivers/base/power/main.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -1281,9 +1281,11 @@
 		dev->power.must_resume = true;

 	if (dev->power.must_resume) {
-		if (dev_pm_test_driver_flags(dev, DPM_FLAG_SMART_SUSPEND)) {
+		if (dev_pm_test_driver_flags(dev, DPM_FLAG_SMART_SUSPEND) &&
+		    !pm_runtime_no_support(dev)) {
 			dev->power.set_active = true;
-			if (dev->parent && !dev->parent->power.ignore_children)
+			if (dev->parent && !dev->parent->power.ignore_children &&
+			    !pm_runtime_no_support(dev->parent))
 				dev->parent->power.set_active = true;
 		}
 		dpm_superior_set_must_resume(dev);