linux-kernel - Re: [PATCH v3] selftests: tpm2: test_smoke: use POSIX-conformant expression operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6vcYJjC7vEpf5Um@kernel.org>
Date: Wed, 12 Feb 2025 01:25:20 +0200
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Ahmed Salem <x0rw3ll@...il.com>
Cc: peterhuewe@....de, jgg@...pe.ca, shuah@...nel.org,
	skhan@...uxfoundation.org, linux-integrity@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH v3] selftests: tpm2: test_smoke: use POSIX-conformant
 expression operator

On Wed, Feb 12, 2025 at 01:05:02AM +0200, Ahmed Salem wrote:
> On 25/02/11 08:10PM, Jarkko Sakkinen wrote:
> > On Tue Feb 11, 2025 at 5:00 AM EET, Ahmed Salem wrote:
> > > Use POSIX-conformant operator symbol '='.
> > >
> > > Signed-off-by: Ahmed Salem <x0rw3ll@...il.com>
> > > ---
> > >
> > > Apologies for my previous mistakes.
> > >
> > > Changes in v3:
> > >  - Reword mistaken commit message
> > >
> > > Changes in v2:
> > >  - Remove snippets pinpointing the issue 
> > >    from commit message
> > 
> > OK I read what I wrote and I guess it could have been misinterpreted.
> > 
> > What I meant was to take the relevant part of the transcript that shows
> > the issue (and possibly also how it works when fixed).
> > 
> > Sorry about that.
> > 
> > [1] https://lore.kernel.org/linux-integrity/D7OY3ZVGJOV5.R3SL9SBFT2DF@kernel.org/
> > 
> > BR, Jarkko
> 
> Understood. Thank you so much for your review and continued guidance!
> 
> I will be sending the revised patch shortly with the proposed changes.

Yeah, like narrow down the transcript that's all, and yep what I said
was somewhat misguiding...

BR, Jarkko