linux-kernel - Re: [PATCH v4] selftests: tpm2: test_smoke: use POSIX-conformant expression operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6vcnSv-fjzRQ1hy@kernel.org>
Date: Wed, 12 Feb 2025 01:26:21 +0200
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Ahmed Salem <x0rw3ll@...il.com>
Cc: peterhuewe@....de, jgg@...pe.ca, shuah@...nel.org,
	skhan@...uxfoundation.org, linux-integrity@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v4] selftests: tpm2: test_smoke: use POSIX-conformant
 expression operator

On Wed, Feb 12, 2025 at 01:16:17AM +0200, Ahmed Salem wrote:
> Use POSIX-conformant expression operator symbol '='.
> 
> The use of the non POSIX-conformant symbol '==' would work 
> in bash, but not in sh where the unexpected operator error 
> would result in test_smoke.sh being skipped.
> 
> Instead of changing the shebang to use bash, which may not be 
> available on all systems, use the POSIX-conformant expression 
> symbol '=' to test for equality.
> 
> Without this patch:
> ===================
>  # make -j8 TARGETS=tpm2 kselftest
>  # selftests: tpm2: test_smoke.sh
>  # ./test_smoke.sh: 9: [: 2: unexpected operator
>  ok 1 selftests: tpm2: test_smoke.sh # SKIP
> 
> With this patch:
> ================
>  # make -j8 TARGETS=tpm2 kselftest
>  # selftests: tpm2: test_smoke.sh
>  # Ran 9 tests in 9.236s
>  ok 1 selftests: tpm2: test_smoke.sh
> 
> Signed-off-by: Ahmed Salem <x0rw3ll@...il.com>

Perfect, thanks a lot.

Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

Shuah, do you want to pick this or?

BR, Jarkko