linux-kernel - Re: [PATCH] mm: pgtable: Unlock pml without branches when !start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250211155016.857387cd35e19a463d779cae@linux-foundation.org>
Date: Tue, 11 Feb 2025 15:50:16 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: I Hsin Cheng <richard120310@...il.com>
Cc: zhengqi.arch@...edance.com, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, jserv@...s.ncku.edu.tw
Subject: Re: [PATCH] mm: pgtable: Unlock pml without branches when
 !start_pte

On Tue, 11 Feb 2025 14:49:47 +0800 I Hsin Cheng <richard120310@...il.com> wrote:

> >       if (ptl != pml)
> > +out_unlock:
> >               spin_unlock(pml);
> >  }
> > _
> >
> > but that's really ugly.
> 
> I agree. Would you be so nice to suggest some test method for me so I
> can try to test how much benefit we can get from this?
> 
> If the case happens frequently enough I think it might be worth it?

I expect this error patch is basically never taken - put a printk in
there and run some tests?