linux-kernel - Re: [PATCH v5 2/2] lib/prime_numbers: convert self-test to KUnit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

[an error occurred while processing this directive]

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502101836.2B3E7BC4@keescook>
Date: Mon, 10 Feb 2025 18:37:25 -0800
From: Kees Cook <kees@...nel.org>
To: Tamir Duberstein <tamird@...il.com>
Cc: David Gow <davidgow@...gle.com>, Shuah Khan <skhan@...uxfoundation.org>,
	Luis Felipe Hernandez <luis.hernandez093@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v5 2/2] lib/prime_numbers: convert self-test to KUnit

On Sat, Feb 08, 2025 at 09:44:39PM -0500, Tamir Duberstein wrote:
> Extract a private header and convert the prime_numbers self-test to a
> KUnit test. I considered parameterizing the test using
> `KUNIT_CASE_PARAM` but didn't see how it was possible since the test
> logic is entangled with the test parameter generation logic.
> 
> Signed-off-by: Tamir Duberstein <tamird@...il.com>
> ---
>  lib/Kconfig.debug                            | 14 +++++
>  lib/math/prime_numbers.c                     | 87 +++++-----------------------
>  lib/math/prime_numbers_private.h             | 17 ++++++
>  lib/math/tests/Makefile                      |  1 +
>  lib/math/tests/prime_numbers_kunit.c         | 59 +++++++++++++++++++
>  tools/testing/selftests/lib/config           |  1 -
>  tools/testing/selftests/lib/prime_numbers.sh |  4 --
>  7 files changed, 106 insertions(+), 77 deletions(-)

Thanks! I've applied this and rebased it onto:
https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/move-kunit-tests

-- 
Kees Cook