linux-kernel - Re: [PATCH v3] f_midi_complete to call tasklet_hi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025021148-expectant-rendering-1019@gregkh>
Date: Tue, 11 Feb 2025 06:59:26 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Jillian Donahue <jilliandonahue58@...il.com>
Cc: kernel test robot <lkp@...el.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
	oe-kbuild-all@...ts.linux.dev, stable@...r.kernel.org
Subject: Re: [PATCH v3] f_midi_complete to call tasklet_hi_schedule

On Mon, Feb 10, 2025 at 10:18:13AM -0700, Jillian Donahue wrote:
> Ah yea, this error happens because in this commit:
> https://github.com/torvalds/linux/commit/8653d71ce3763aedcf3d2331f59beda3fecd79e4
> the tasklets are replaced with works. Should I request the patch to be
> in v5.10 or should I update the fix to use
> queue_work(system_highpri_wq, &midi->work) ?
> 
> > >> drivers/usb/gadget/function/f_midi.c:286:31: error: no member named 'tasklet' in 'struct f_midi'
> >      286 |                         tasklet_hi_schedule(&midi->tasklet);
> >          |                                              ~~~~  ^
> >    1 error generated.

Always submit your changes based on the latest kernel tree (ideally the
latest development tree).  Any older kernel backports can happen after
they end up in a release.

thanks,

greg k-h