linux-kernel - Re: [PATCH] hid: Kconfig: Add LEDS_CLASS_MULTICOLOR dependency to HID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <q58263op-297n-255q-npo9-0676o0os9q37@xreary.bet>
Date: Tue, 11 Feb 2025 07:30:55 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Kate Hsuan <hpa@...hat.com>
cc: Hans de Goede <hdegoede@...hat.com>, 
    Benjamin Tissoires <bentiss@...nel.org>, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] hid: Kconfig: Add LEDS_CLASS_MULTICOLOR dependency to
 HID_LOGITECH

On Tue, 11 Feb 2025, Kate Hsuan wrote:

> The test bot found an issue with building hid-lg-g15.
> 
> All errors (new ones prefixed by >>):
> 
>    powerpc-linux-ld: drivers/hid/hid-lg-g15.o: in function `lg_g510_kbd_led_write':
> >> drivers/hid/hid-lg-g15.c:241:(.text+0x768): undefined reference to `led_mc_calc_color_components'
>    powerpc-linux-ld: drivers/hid/hid-lg-g15.o: in function `lg_g15_register_led':
> >> drivers/hid/hid-lg-g15.c:686:(.text+0xa9c): undefined reference to `devm_led_classdev_multicolor_register_ext'
> 
> Since multicolor LED APIs manage the keyboard backlight settings of
> hid-lg-g15, the LEDS_CLASS_MULTICOLOR dependency was added to
> HID_LOGITECH.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502110032.VZ0J024X-lkp@intel.com/
> Signed-off-by: Kate Hsuan <hpa@...hat.com>

I've added

	Fixes: a3a064146c50 ("HID: hid-lg-g15: Use standard multicolor LED API")

make the 'HID:' prefix in shortlog uppercase, and applied.

Thanks,

-- 
Jiri Kosina
SUSE Labs