linux-kernel - Re: [PATCH net-next v2] af_unix: Fix undefined 'other' error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250211003203.81463-1-kuniyu@amazon.com>
Date: Tue, 11 Feb 2025 09:32:03 +0900
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <purvayeshi550@...il.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <horms@...nel.org>,
	<kuba@...nel.org>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>, <skhan@...uxfoundation.org>, Kuniyuki Iwashima
	<kuniyu@...zon.com>
Subject: Re: [PATCH net-next v2] af_unix: Fix undefined 'other' error

From: Purva Yeshi <purvayeshi550@...il.com>
Date: Mon, 10 Feb 2025 13:20:06 +0530
> Fix issue detected by smatch tool:
> An "undefined 'other'" error occur in __releases() annotation.
> 
> Fix an undefined 'other' error in unix_wait_for_peer() caused by  
> __releases(&unix_sk(other)->lock) being placed before 'other' is in  
> scope. Since AF_UNIX does not use Sparse annotations, remove it to fix  
> the issue.  
> 
> Eliminate the error without affecting functionality.  

The 5 lines of the 3 sentences above have trailing double spaces.
You may want to configure your editor to highlight them.

e.g. for emacs

(setq-default show-trailing-whitespace t)


> 
> Signed-off-by: Purva Yeshi <purvayeshi550@...il.com>

Otherwise looks good.

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>