linux-kernel - Re: (subset) [PATCH v11 3/3] leds: Add LED1202 I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXtDd-KSeX_8nhj_J0X33WRT47_v3m01qdBN01-p4xVjA@mail.gmail.com>
Date: Tue, 11 Feb 2025 09:02:34 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Lee Jones <lee@...nel.org>
Cc: Pavel Machek <pavel@....cz>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Jonathan Corbet <corbet@....net>, linux-leds@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, 
	Vicentiu Galanopulo <vicentiu.galanopulo@...ote-tech.co.uk>
Subject: Re: (subset) [PATCH v11 3/3] leds: Add LED1202 I2C driver

Hi Lee,

On Mon, 10 Feb 2025 at 18:01, Lee Jones <lee@...nel.org> wrote:
> On Mon, 10 Feb 2025, Lee Jones wrote:
> > On Tue, 21 Jan 2025, Geert Uytterhoeven wrote:
> >
> > > Hi Lee,
> > >
> > > On Thu, Jan 9, 2025 at 11:31 AM Lee Jones <lee@...nel.org> wrote:
> > > > On Wed, 18 Dec 2024 18:33:59 +0000, Vicentiu Galanopulo wrote:
> > > > > The output current can be adjusted separately for each channel by 8-bit
> > > > > analog (current sink input) and 12-bit digital (PWM) dimming control. The
> > > > > LED1202 implements 12 low-side current generators with independent dimming
> > > > > control.
> > > > > Internal volatile memory allows the user to store up to 8 different patterns,
> > > > > each pattern is a particular output configuration in terms of PWM
> > > > > duty-cycle (on 4096 steps). Analog dimming (on 256 steps) is per channel but
> > > > > common to all patterns. Each device tree LED node will have a corresponding
> > > > > entry in /sys/class/leds with the label name. The brightness property
> > > > > corresponds to the per channel analog dimming, while the patterns[1-8] to the
> > > > > PWM dimming control.
> > > > >
> > > > > [...]
> > > >
> > > > Applied, thanks!
> > > >
> > > > [3/3] leds: Add LED1202 I2C driver
> > > >       commit: 939757aafeb9c266dda37657ee5f7a73ffd35ae2
> > >
> > > You also have commit 259230378c65ebb6 ("leds: Add LED1202 I2C driver")
> > > in mfd/for-mfd-next, which dropped the change to drivers/leds/Makefile,
> > > and changed the Link:-tag to point to the older version v10?
> >
> > Interesting.  Not sure I noticed and if I did, I must have fixed it.
> >
> > This is the commit that made it in:
> >
> >   939757aafeb9 ("leds: Add LED1202 I2C driver")
>
> Scratch that - looks like:
>
>   259230378c65 ("leds: Add LED1202 I2C driver")
>
> ... also made it in.  However the Makefile line survived:
>
>   drivers/leds/Makefile:obj-$(CONFIG_LEDS_ST1202)         += leds-st1202.o
>
> Did anything break or is all as expected?

The end result is fine.  History might confuse people (the (un)happy
few who care about history ;-), as "git log -p v6.14-rc1 --
drivers/leds/Makefile" shows 939757aafeb9, while "git log -p v6.14-rc1
-- drivers/leds/leds-st1202.c" shows 259230378c65, linking to the
older version.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds