linux-kernel - Re: [PATCH V4] KVM: SEV: fix wrong pinning of pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <897102c0-7b5e-4495-9f21-573beb338925@redhat.com>
Date: Tue, 11 Feb 2025 10:06:06 +0100
From: David Hildenbrand <david@...hat.com>
To: yangge1116@....com, pbonzini@...hat.com
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org, seanjc@...gle.com,
 21cnbao@...il.com, baolin.wang@...ux.alibaba.com, thomas.lendacky@....com,
 liuzixing@...on.cn
Subject: Re: [PATCH V4] KVM: SEV: fix wrong pinning of pages

On 11.02.25 03:37, yangge1116@....com wrote:
> From: Ge Yang <yangge1116@....com>
> 
> In the sev_mem_enc_register_region() function, we need to call
> sev_pin_memory() to pin memory for the long term. However, when
> calling sev_pin_memory(), the FOLL_LONGTERM flag is not passed, causing
> the allocated pages not to be migrated out of MIGRATE_CMA/ZONE_MOVABLE,
> violating these mechanisms to avoid fragmentation with unmovable pages,
> for example making CMA allocations fail.
> 
> To address the aforementioned problem, we should add the FOLL_LONGTERM
> flag when calling sev_pin_memory() within the sev_mem_enc_register_region()
> function.
> 
> Signed-off-by: Ge Yang <yangge1116@....com>
> Reviewed-by: Tom Lendacky <thomas.lendacky@....com>
> ---

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb