linux-kernel - Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for sysmgr node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d78ae428-6139-426b-bde9-e3ce5a4008ac@kernel.org>
Date: Mon, 10 Feb 2025 18:06:46 -0600
From: Dinh Nguyen <dinguyen@...nel.org>
To: niravkumar.l.rabara@...el.com, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] ARM: dts: socfpga: remove syscon compatible string for
 sysmgr node

On 2/10/25 16:29, Dinh Nguyen wrote:
> On 1/17/25 09:42, niravkumar.l.rabara@...el.com wrote:
>> From: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
>>
>> The SoCFPGA System Manager(sysmgr) dt bindings do not use the syscon
>> compitible, nor does the Linux system manager driver rely on it.
>> Remove "syscon" for Arria5, Arria10 and Cyclon5 sysmgr node and fixed
>> dtbs_check warnings like:
>>
>> socfpga_arria5_socdk.dtb: sysmgr@...08000: compatible: 'oneOf' 
>> conditional failed, one must be fixed:
>>     ['altr,sys-mgr', 'syscon'] is too long
>>     'altr,sys-mgr-s10' was expected
>>     'altr,sys-mgr' was expected
>>     from schema $id: 
>> http://devicetree.org/schemas/soc/altera/altr,sys-mgr.yaml#
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: 
>> https://lore.kernel.org/oe-kbuild-all/202501102323.Xnte2yhi-lkp@intel.com/
>> Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>
>> ---
>>   arch/arm/boot/dts/intel/socfpga/socfpga.dtsi         | 2 +-
>>   arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga.dtsi 
>> b/arch/arm/boot/dts/intel/socfpga/socfpga.dtsi
>> index 35be14150f41..f124fb72e260 100644
>> --- a/arch/arm/boot/dts/intel/socfpga/socfpga.dtsi
>> +++ b/arch/arm/boot/dts/intel/socfpga/socfpga.dtsi
>> @@ -853,7 +853,7 @@ spi1: spi@...01000 {
>>           };
>>           sysmgr: sysmgr@...08000 {
>> -            compatible = "altr,sys-mgr", "syscon";
>> +            compatible = "altr,sys-mgr";
>>               reg = <0xffd08000 0x4000>;
>>           };
>> diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi 
>> b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi
>> index 6b6e77596ffa..015120fb4b02 100644
>> --- a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi
>> +++ b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi
>> @@ -792,7 +792,7 @@ scu: snoop-control-unit@...fc000 {
>>           };
>>           sysmgr: sysmgr@...06000 {
>> -            compatible = "altr,sys-mgr", "syscon";
>> +            compatible = "altr,sys-mgr";
>>               reg = <0xffd06000 0x300>;
>>               cpu1-start-addr = <0xffd06230>;
>>           };
> 
> Did you test this patch on actual hardware? Unless something has changed 
> in the system manager driver, this will probably cause the system hang.
>

Actually, it will not fail to boot, but you will see SD/MMC fail if the 
bootloader did not set the clk-phase correctly, or you booted from 
another source not SD/MMC. The SD/MMC driver uses syscon to get access 
to the system manager to set it's clk-phase.

Dinh

Dinh