linux-kernel - Re: [PATCH 1/2] mm/mmu_gather: remove unused __tlb_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6sh4BydNRi9iarR@MiWiFi-R3L-srv>
Date: Tue, 11 Feb 2025 18:09:36 +0800
From: Baoquan He <bhe@...hat.com>
To: Qi Zheng <zhengqi.arch@...edance.com>
Cc: linux-mm@...ck.org, akpm@...ux-foundation.org, will@...nel.org,
	aneesh.kumar@...nel.org, npiggin@...il.com, peterz@...radead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mm/mmu_gather: remove unused __tlb_remove_page()

On 02/11/25 at 03:45pm, Qi Zheng wrote:
> 
> 
> On 2025/2/11 11:43, Baoquan He wrote:
> > Nobody is using __tlb_remove_page() now, clean it up.
> > 
> > Signed-off-by: Baoquan He <bhe@...hat.com>
> > ---
> >   include/asm-generic/tlb.h | 6 ------
> >   1 file changed, 6 deletions(-)
> > 
> > diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h
> > index e402aef79c93..9ae4ca02f29f 100644
> > --- a/include/asm-generic/tlb.h
> > +++ b/include/asm-generic/tlb.h
> > @@ -489,12 +489,6 @@ static inline void tlb_remove_page_size(struct mmu_gather *tlb,
> >   		tlb_flush_mmu(tlb);
> >   }
> > -static __always_inline bool __tlb_remove_page(struct mmu_gather *tlb,
> > -		struct page *page, bool delay_rmap)
> > -{
> > -	return __tlb_remove_page_size(tlb, page, delay_rmap, PAGE_SIZE);
> > -}
> > -
> >   /* tlb_remove_page
> >    *	Similar to __tlb_remove_page but will call tlb_flush_mmu() itself when
> 
>                    ^
>                    please update this too

Good catch, will remove the unneeded code comment. Thanks for reviewing.

> 
> Otherwise:
> 
> Reviewed-by: Qi Zheng <zhengqi.arch@...edance.com>
> 
> >    *	required.
>