linux-kernel - Re: [PATCH] usb: xhci: Initialize unassigned variables to fix possible errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1296674576.21739268902551.JavaMail.epsvc@epcpadp1new>
Date: Tue, 11 Feb 2025 17:37:13 +0900
From: Selvarasu G <selvarasu.g@...sung.com>
To: Greg KH <gregkh@...uxfoundation.org>
CC: "mathias.nyman@...el.com" <mathias.nyman@...el.com>,
	"WeitaoWang-oc@...oxin.com" <WeitaoWang-oc@...oxin.com>,
	"Thinh.Nguyen@...opsys.com" <Thinh.Nguyen@...opsys.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, JaeHun Jung
	<jh0801.jung@...sung.com>, JUNG Daehwan <dh10.jung@...sung.com>, NAUSHAD
	KOLLIKKARA <naushad@...sung.com>, Akash M <akash.m5@...sung.com>, Hyunsoon
	Kim <h10.kim@...sung.com>, OH Eomji <eomji.oh@...sung.com>, ALIM AKHTAR
	<alim.akhtar@...sung.com>, Thiagu Ramalingam <thiagu.r@...sung.com>,
	Muhammed Ali K P <muhammed.ali@...sung.com>, Pritam Manohar Sutar
	<pritam.sutar@...sung.com>, CPGS <cpgs@...sung.com>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] usb: xhci: Initialize unassigned variables to fix
 possible errors

On 2/11/2025 11:28 AM, Greg KH wrote:
> On Mon, Feb 10, 2025 at 06:41:23PM +0530, Selvarasu Ganesan wrote:
>> Fix the following smatch errors:
>>
>> drivers/usb/host/xhci-mem.c:2060 xhci_add_in_port() error: unassigned variable 'tmp_minor_revision'
>> drivers/usb/host/xhci-hub.c:71 xhci_create_usb3x_bos_desc() error: unassigned variable 'bcdUSB'
>>
>> Fixes: d9b0328d0b8b ("xhci: Show ZHAOXIN xHCI root hub speed correctly")
>> Fixes: eb02aaf21f29 ("usb: xhci: Rewrite xhci_create_usb3_bos_desc()")
> This should be two different changes, right?
>
> Please break it up and send as a patch series.
>
> thanks,
>
> greg k-h


Hi Greg,

Thanks for your comments. Sure i will send as a patch series.

Thanks,
Selva