linux-kernel - Re: [PATCH 0/3] media: qcom: camss: Add sa8775p camss TPG support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <012b0381-a5d1-49bc-aa59-aae0d35aa034@linaro.org>
Date: Tue, 11 Feb 2025 10:19:12 +0000
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Wenmeng Liu <quic_wenmliu@...cinc.com>, Robert Foss <rfoss@...nel.org>,
 Todor Tomov <todor.too@...il.com>, Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 0/3] media: qcom: camss: Add sa8775p camss TPG support

On 11/02/2025 10:07, Wenmeng Liu wrote:
> SA8775P is a Qualcomm SoC. This series adds driver changes to
> bring up the TPG interfaces in SA8775P.
> 
> We have tested this on qcs9100-ride board with 'Test Pattern Generator'.
> Unlike CSID TPG, this TPG can be seen as a combination of CSIPHY and sensor.
> 
> Tested with following commands:
> - media-ctl --reset
> - v4l2-ctl -d /dev/v4l-subdev0 -c test_pattern=0
> - media-ctl -V '"msm_tpg0":0[fmt:SRGGB10/4608x2592 field:none]'
> - media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4608x2592 field:none]'
> - media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4608x2592 field:none]'
> - media-ctl -l '"msm_tpg0":1->"msm_csid0":0[1]'
> - media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
> - v4l2-ctl -d /dev/v4l-subdev0 -c test_pattern=9
> - yavta -B capture-mplane -n 5 -f SRGGB10P -s 4608x2592 /dev/video0
>    --capture=7
> 
> Used following tools for the sanity check of these changes.
> 
> - make -j32 W=1
> - ./scripts/checkpatch.pl
> 
> ---
> This patch series depends on patch series:
> https://lore.kernel.org/linux-media/20250210162843.609337-1-quic_vikramsa@quicinc.com/
> ---
> 
> ---
> Wenmeng Liu (3):
>        media: qcom: camss: Add support for TPG common
>        media: qcom: camss: Add link support for TPG common
>        media: qcom: camss: tpg: Add TPG support for SA8775P
> 
>   drivers/media/platform/qcom/camss/Makefile         |   2 +
>   drivers/media/platform/qcom/camss/camss-csid-690.c |  15 +
>   drivers/media/platform/qcom/camss/camss-csid.c     |  44 +-
>   drivers/media/platform/qcom/camss/camss-tpg-gen1.c | 245 +++++++
>   drivers/media/platform/qcom/camss/camss-tpg.c      | 737 +++++++++++++++++++++
>   drivers/media/platform/qcom/camss/camss-tpg.h      | 130 ++++
>   drivers/media/platform/qcom/camss/camss.c          | 113 ++++
>   drivers/media/platform/qcom/camss/camss.h          |   5 +
>   8 files changed, 1282 insertions(+), 9 deletions(-)
> ---
> base-commit: c1696380f08cf7cc68560a11f2e8c51cb24aa7ba
> change-id: 20250211-sa8775p_tpg-7de227a82eb4
> 
> Best regards,

Great to see this work.

I think the TPG should be another type of PHY.

---
bod