linux-kernel - Re: [PATCH 01/13] drm/vkms: Extract vkms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6sogfnUBv0dVln3@fedora>
Date: Tue, 11 Feb 2025 11:37:53 +0100
From: José Expósito <jose.exposito89@...il.com>
To: Louis Chauvet <louis.chauvet@...tlin.com>
Cc: hamohammed.sa@...il.com, simona@...ll.ch, melissa.srw@...il.com,
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
	tzimmermann@...e.de, airlied@...il.com,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/13] drm/vkms: Extract vkms_connector header

Hi Louis,

First of all, thanks a lot for the review.

I applied all changes you suggested and, especially thanks to the
iterators you suggested, the code is way cleaner and simpler now.

I'll send v2 in a bit, but first I'll comment on some of your
reviews to clarify some porints:

On Thu, Jan 30, 2025 at 02:48:10PM +0100, Louis Chauvet wrote:
> On 29/01/25 - 12:00, José Expósito wrote:
> > Up until now, the logic to manage connectors was in vkms_output.c.
> > 
> > Since more options will be added to connectors in the future, extract
> > the code to its own file.
> > 
> > Refactor, no functional changes.
> > 
> > Signed-off-by: José Expósito <jose.exposito89@...il.com>
> 
> Non blocking issue: Do you think it is possible to split this in two 
> different commits: one to create vkms_connector.h/c and one to create 
> struct vkms_connector?

Done, I split this patch in 2 in v2.

> 
> Reviewed-by: Louis Chauvet <louis.chauvet@...tlin.com>
> 
> [...]