linux-kernel - Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eebcc0e7-4f87-45d5-8ad4-9d24145ef5b2@kernel.org>
Date: Tue, 11 Feb 2025 12:03:36 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Cheng Jiang <quic_chejiang@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, quic_jiaymao@...cinc.com,
 quic_shuaz@...cinc.com, quic_zijuhu@...cinc.com, quic_mohamull@...cinc.com
Subject: Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on
 qcs8300-ride

On 11/02/2025 11:44, Cheng Jiang wrote:
>  	};
>  };
>  
> +&uart2 {
> +	status = "okay";
> +	bluetooth: bluetooth {

Why do you need the label?

> +		compatible = "qcom,wcn6855-bt";
> +		firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&bt_en_state>;
> +		enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
> +
> +		vddio-supply       = <&vreg_conn_pa>;         /* bt-vdd-ctrl1-supply */
> +		vddbtcxmx-supply   = <&vreg_conn_1p8>;        /* bt-vdd-ctrl2-supply */

Only one space before '='.

I think this has multiple test failures.

Best regards,
Krzysztof