linux-kernel - Re: (subset) [PATCH v2 0/3] gpiolib: refactor for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173937006403.31129.5577338516228495218.b4-ty@linaro.org>
Date: Wed, 12 Feb 2025 15:21:39 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: (subset) [PATCH v2 0/3] gpiolib: refactor for_each_hwgpio()

From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>


On Fri, 07 Feb 2025 17:07:33 +0200, Andy Shevchenko wrote:
> Some of the for_each_*() macros use the very similar piece of code
> that may be deduplicated (by introducing a new helper macro in patch 1).
> On top of that the implementation of the low-level for_each_hwgpio_in_range()
> looks too verbose. Try to simplify it (patches 2 and 3).
> 
> Changelog v2:
> - added kernel-doc for a new helper (Bart)
> - added two more patches
> 
> [...]

I applied patches 1 and 2. Please revisit 3/3 in order to not duplicate
the for_each_if() macro.

[1/3] gpiolib: Deduplicate some code in for_each_requested_gpio_in_range()
      commit: 8893516000b247f91fa2cef34f2a77b609e661a4
[2/3] gpiolib: Simplify implementation of for_each_hwgpio_in_range()
      commit: 767412f092fc6e04147305acd70f15770ece47ec

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>