linux-kernel - Re: [PATCH net-next] net: wwan: mhi_wwan_mbim: Silence sequence number glitch errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZdPi8pybqtKQq9irxwGwvW9y3EC=g9XkbZ4hthBkXQRUxUDQ@mail.gmail.com>
Date: Wed, 12 Feb 2025 15:25:21 +0100
From: Loic Poulain <loic.poulain@...aro.org>
To: Stephan Gerhold <stephan.gerhold@...aro.org>
Cc: Sergey Ryazanov <ryazanov.s.a@...il.com>, Johannes Berg <johannes@...solutions.net>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Johan Hovold <johan@...nel.org>, Abel Vesa <abel.vesa@...aro.org>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Subject: Re: [PATCH net-next] net: wwan: mhi_wwan_mbim: Silence sequence
 number glitch errors

On Wed, 12 Feb 2025 at 12:15, Stephan Gerhold
<stephan.gerhold@...aro.org> wrote:
>
> When using the Qualcomm X55 modem on the ThinkPad X13s, the kernel log is
> constantly being filled with errors related to a "sequence number glitch",
> e.g.:
>
>         [ 1903.284538] sequence number glitch prev=16 curr=0
>         [ 1913.812205] sequence number glitch prev=50 curr=0
>         [ 1923.698219] sequence number glitch prev=142 curr=0
>         [ 2029.248276] sequence number glitch prev=1555 curr=0
>         [ 2046.333059] sequence number glitch prev=70 curr=0
>         [ 2076.520067] sequence number glitch prev=272 curr=0
>         [ 2158.704202] sequence number glitch prev=2655 curr=0
>         [ 2218.530776] sequence number glitch prev=2349 curr=0
>         [ 2225.579092] sequence number glitch prev=6 curr=0
>
> Internet connectivity is working fine, so this error seems harmless. It
> looks like modem does not preserve the sequence number when entering low
> power state; the amount of errors depends on how actively the modem is
> being used.
>
> A similar issue has also been seen on USB-based MBIM modems [1]. However,
> in cdc_ncm.c the "sequence number glitch" message is a debug message
> instead of an error. Apply the same to the mhi_wwan_mbim.c driver to
> silence these errors when using the modem.
>
> [1]: https://lists.freedesktop.org/archives/libmbim-devel/2016-November/000781.html
>
> Signed-off-by: Stephan Gerhold <stephan.gerhold@...aro.org>

Reviewed-by: Loic Poulain <loic.poulain@...aro.org>