linux-kernel - Re: [PATCH v3 5/7] clk: eyeq: use the auxiliary device creation helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D7QJVKCWO1C0.2GIZNZ9FUF96I@bootlin.com>
Date: Wed, 12 Feb 2025 15:51:32 +0100
From: Théo Lebrun <theo.lebrun@...tlin.com>
To: "Jerome Brunet" <jbrunet@...libre.com>, "Greg Kroah-Hartman"
 <gregkh@...uxfoundation.org>, "Dave Ertman" <david.m.ertman@...el.com>,
 "Ira Weiny" <ira.weiny@...el.com>, "Rafael J. Wysocki" <rafael@...nel.org>,
 "Stephen Boyd" <sboyd@...nel.org>, "Arnd Bergmann" <arnd@...db.de>, "Danilo
 Krummrich" <dakr@...nel.org>, "Conor Dooley" <conor.dooley@...rochip.com>,
 "Daire McNamara" <daire.mcnamara@...rochip.com>, "Philipp Zabel"
 <p.zabel@...gutronix.de>, "Douglas Anderson" <dianders@...omium.org>,
 "Andrzej Hajda" <andrzej.hajda@...el.com>, "Neil Armstrong"
 <neil.armstrong@...aro.org>, "Robert Foss" <rfoss@...nel.org>, "Laurent
 Pinchart" <Laurent.pinchart@...asonboard.com>, "Jonas Karlman"
 <jonas@...boo.se>, "Jernej Skrabec" <jernej.skrabec@...il.com>, "Maarten
 Lankhorst" <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard"
 <mripard@...nel.org>, "Thomas Zimmermann" <tzimmermann@...e.de>, "David
 Airlie" <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "Hans de
 Goede" <hdegoede@...hat.com>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>, "Bryan O'Donoghue"
 <bryan.odonoghue@...aro.org>, "Vladimir Kondratiev"
 <vladimir.kondratiev@...ileye.com>, "Gregory CLEMENT"
 <gregory.clement@...tlin.com>, "Michael Turquette"
 <mturquette@...libre.com>, "Abel Vesa" <abelvesa@...nel.org>, "Peng Fan"
 <peng.fan@....com>, "Shawn Guo" <shawnguo@...nel.org>, "Sascha Hauer"
 <s.hauer@...gutronix.de>, "Pengutronix Kernel Team"
 <kernel@...gutronix.de>, "Fabio Estevam" <festevam@...il.com>, "Kevin
 Hilman" <khilman@...libre.com>, "Martin Blumenstingl"
 <martin.blumenstingl@...glemail.com>
Cc: <linux-kernel@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
 <dri-devel@...ts.freedesktop.org>, <platform-driver-x86@...r.kernel.org>,
 <linux-mips@...r.kernel.org>, <linux-clk@...r.kernel.org>,
 <imx@...ts.linux.dev>, <linux-arm-kernel@...ts.infradead.org>,
 <linux-amlogic@...ts.infradead.org>, "Philipp Zabel"
 <p.zabel@...gutronix.de>
Subject: Re: [PATCH v3 5/7] clk: eyeq: use the auxiliary device creation
 helper

Hello Jerome,

On Tue Feb 11, 2025 at 6:28 PM CET, Jerome Brunet wrote:
> The auxiliary device creation of this driver is simple enough to
> use the available auxiliary device creation helper.
>
> Use it and remove some boilerplate code.
>
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>

Tested the series, it works. However:
 - The newly introduced helper does a
   device_set_of_node_from_dev(child_device, parent_device) call which
   used to be done by our reset-eyeq child.
 - reset-eyeq also did a WARN_ON(dev->of_node) to validate it didn't
   have an OF node at probe (checking its assumptions).
 - We can remove both. See patch that got sent as a reply.

With that additional patch:

Tested-by: Théo Lebrun <theo.lebrun@...tlin.com>  # On Mobileye EyeQ5

Note: Philipp Zabel has been CCed on the patch and this email as the
reset maintainer.

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com