linux-kernel - Re: [PATCH 2/3] regulator: qcom_usb_vbus: Add support for PMI8998 VBUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <15c4579d-5053-4d7f-8a2a-b29e80240118@sirena.org.uk>
Date: Wed, 12 Feb 2025 00:09:12 +0000
From: Mark Brown <broonie@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: "James A. MacInnes" <james.a.macinnes@...il.com>,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, andersson@...nel.org,
	konradybcio@...nel.org, quic_wcheng@...cinc.com, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, lgirdwood@...il.com
Subject: Re: [PATCH 2/3] regulator: qcom_usb_vbus: Add support for PMI8998
 VBUS

On Wed, Feb 12, 2025 at 01:16:37AM +0200, Dmitry Baryshkov wrote:
> On Tue, Feb 11, 2025 at 11:49:15AM -0800, James A. MacInnes wrote:

> > +	pmic_type = of_device_get_match_data(dev);
> > +	if (pmic_type && strcmp(pmic_type, "pmi8998") == 0) {

> I think a traditional way is to define an enum and then use that enum
> values as match data. Or you can just add a struct with curr_table and
> get that as a match data.

Either approach works, yeah.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)