linux-kernel - Re: [PATCH RESEND 5/7] mfd: cs40l26: Add support for CS40L26 core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c92f8f5b-e6f4-41bb-86c1-dc45b80cd49b@opensource.cirrus.com>
Date: Wed, 12 Feb 2025 15:10:51 +0000
From: Richard Fitzgerald <rf@...nsource.cirrus.com>
To: Fred Treven <ftreven@...nsource.cirrus.com>,
        Krzysztof Kozlowski
	<krzk@...nel.org>, Lee Jones <lee@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Simon Trimmer <simont@...nsource.cirrus.com>,
        Charles Keepax
	<ckeepax@...nsource.cirrus.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        James Ogletree <jogletre@...nsource.cirrus.com>,
        Ben Bright
	<ben.bright@...rus.com>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown
	<broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
	<tiwai@...e.com>,
        David Rhodes <david.rhodes@...rus.com>,
        Jeff LaBundy
	<jeff@...undy.com>, Heiko Stuebner <heiko@...ech.de>,
        Karel Balej
	<balejk@...fyz.cz>,
        Igor Prusov <ivprusov@...utedevices.com>,
        Jack Yu
	<jack.yu@...ltek.com>,
        Weidong Wang <wangweidong.a@...nic.com>,
        Binbin Zhou
	<zhoubinbin@...ngson.cn>,
        Prasad Kumpatla <quic_pkumpatl@...cinc.com>,
        "Paul
 Handrigan" <paulha@...nsource.cirrus.com>,
        Masahiro Yamada
	<masahiroy@...nel.org>, Nuno Sa <nuno.sa@...log.com>
CC: <alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-input@...r.kernel.org>, <linux-sound@...r.kernel.org>
Subject: Re: [PATCH RESEND 5/7] mfd: cs40l26: Add support for CS40L26 core
 driver

On 11/02/2025 9:16 pm, Fred Treven wrote:
> On 2/5/25 04:34, Krzysztof Kozlowski wrote:
>> On 05/02/2025 00:18, Fred Treven wrote:
>>> Introduce support for Cirrus Logic Device CS40L26:
>>> A boosted haptic driver with integrated DSP and
>>> waveform memory with advanced closed loop algorithms
>>> and LRA protection.
>>>

<SNIP>

>>> +static const struct spi_device_id cs40l26_id_spi[] = {
>>> +    { "cs40l26a", 0 },
>>> +    { "cs40l27b", 1 },
>>
>> What are these 0 and 1?
> 
> I will make it clear that these are enumerating the different possible
> device variants.
> 
> 
>>
>>> +    {}
>>> +};
>>> +MODULE_DEVICE_TABLE(spi, cs40l26_id_spi);
>>> +
>>> +static const struct of_device_id cs40l26_of_match[] = {
>>> +    { .compatible = "cirrus,cs40l26a" },
>>> +    { .compatible = "cirrus,cs40l27b" },
>>
>> So devices are compatible? Or rather this is unsynced with other ID 
>> table.
> I'm not sure what you mean by this.
> 

cs40l26_id_spi[] has the 0/1 cookie values to indicate which part
variant is being instantiated. But cs40l26_of_match[] doesn't have
these cookie values to indicate which part ID was matched.