linux-kernel - Re: [PATCH v2 6/6] unicode: kunit: change tests filename and path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pljnw4r1.fsf@mailhost.krisman.be>
Date: Wed, 12 Feb 2025 10:40:34 -0500
From: Gabriel Krisman Bertazi <krisman@...e.de>
To: Kees Cook <kees@...nel.org>
Cc: David Gow <davidgow@...gle.com>,  Gabriela Bittencourt
 <gbittencourt@...amp.dev>,  Pedro Orlando <porlando@...amp.dev>,  Danilo
 Pereira <dpereira@...amp.dev>,  Shuah Khan <skhan@...uxfoundation.org>,
  Rae Moar <rmoar@...gle.com>,  Luis Felipe Hernandez
 <luis.hernandez093@...il.com>,  Nicolas Pitre <npitre@...libre.com>,
  Diego Vieira <diego.daniel.professional@...il.com>,  "Steven Rostedt
 (Google)" <rostedt@...dmis.org>,  Jakub Kicinski <kuba@...nel.org>,
  "Masami Hiramatsu (Google)" <mhiramat@...nel.org>,  Vlastimil Babka
 <vbabka@...e.cz>,  Bruno Sobreira França
 <brunofrancadevsec@...il.com>,
  linux-kernel@...r.kernel.org,  linux-hardening@...r.kernel.org,
  linux-kselftest@...r.kernel.org,  kunit-dev@...glegroups.com, Thorsten
 Leemhuis <linux@...mhuis.info>
Subject: Re: [PATCH v2 6/6] unicode: kunit: change tests filename and path

Kees Cook <kees@...nel.org> writes:

> From: Gabriela Bittencourt <gbittencourt@...amp.dev>
>
> Change utf8 kunit test filename and path to follow the style
> convention on Documentation/dev-tools/kunit/style.rst
>
> Co-developed-by: Pedro Orlando <porlando@...amp.dev>
> Signed-off-by: Pedro Orlando <porlando@...amp.dev>
> Co-developed-by: Danilo Pereira <dpereira@...amp.dev>
> Signed-off-by: Danilo Pereira <dpereira@...amp.dev>
> Signed-off-by: Gabriela Bittencourt <gbittencourt@...amp.dev>
> Reviewed-by: David Gow <davidgow@...gle.com>
> Acked-by: Gabriel Krisman Bertazi <krisman@...e.de>
> Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>
> Reviewed-by: Rae Moar <rmoar@...gle.com>
> Link: https://lore.kernel.org/r/20241202075545.3648096-7-davidgow@google.com
> Signed-off-by: Kees Cook <kees@...nel.org>

Hi Kees,

Last time this was submitted, I have reported this patch breaks the
build when the kunit is built as a module, and it wasn't fixed before
resubmission.  Thorsten Leemhuis just reported the same issue is now on
linux-next and I confirmed it is still there.

https://lore.kernel.org/lkml/2c26c5e4-9cf3-4020-b0be-637dc826b4e9@leemhuis.info/T/#m2e2ddb3b2600274e5eae50b93ea821914dc85f20

The build error is:

fs/unicode/tests/utf8_kunit.c:11:10: fatal error: utf8n.h: No such file or directory
   11 | #include "utf8n.h"
      |          ^~~~~~~~~

The problem is that the patch moves utf8_kunit.c into tests/ but doesn't
fix the include line above.  Can you fix it in your tree since it is
already merged?

Thanks,

> ---
>  fs/unicode/Makefile                                | 2 +-
>  fs/unicode/{ => tests}/.kunitconfig                | 0
>  fs/unicode/{utf8-selftest.c => tests/utf8_kunit.c} | 0
>  3 files changed, 1 insertion(+), 1 deletion(-)
>  rename fs/unicode/{ => tests}/.kunitconfig (100%)
>  rename fs/unicode/{utf8-selftest.c => tests/utf8_kunit.c} (100%)
>
> diff --git a/fs/unicode/Makefile b/fs/unicode/Makefile
> index 37bbcbc628a1..d95be7fb9f6b 100644
> --- a/fs/unicode/Makefile
> +++ b/fs/unicode/Makefile
> @@ -4,7 +4,7 @@ ifneq ($(CONFIG_UNICODE),)
>  obj-y			+= unicode.o
>  endif
>  obj-$(CONFIG_UNICODE)	+= utf8data.o
> -obj-$(CONFIG_UNICODE_NORMALIZATION_KUNIT_TEST) += utf8-selftest.o
> +obj-$(CONFIG_UNICODE_NORMALIZATION_KUNIT_TEST) += tests/utf8_kunit.o
>  
>  unicode-y := utf8-norm.o utf8-core.o
>  
> diff --git a/fs/unicode/.kunitconfig b/fs/unicode/tests/.kunitconfig
> similarity index 100%
> rename from fs/unicode/.kunitconfig
> rename to fs/unicode/tests/.kunitconfig
> diff --git a/fs/unicode/utf8-selftest.c b/fs/unicode/tests/utf8_kunit.c
> similarity index 100%
> rename from fs/unicode/utf8-selftest.c
> rename to fs/unicode/tests/utf8_kunit.c

-- 
Gabriel Krisman Bertazi