linux-kernel - Re: selftest/vDSO: vdso_test_abi tests with gcc-13 and pass with clang-19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <b7dc96e3-4d8a-4da8-adda-161f8ff815b1@app.fastmail.com>
Date: Wed, 12 Feb 2025 17:23:25 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Naresh Kamboju" <naresh.kamboju@...aro.org>,
 clang-built-linux <llvm@...ts.linux.dev>,
 "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>,
 "open list" <linux-kernel@...r.kernel.org>, lkft-triage@...ts.linaro.org
Cc: "Nathan Chancellor" <nathan@...nel.org>,
 "Nick Desaulniers" <ndesaulniers@...gle.com>,
 "Dan Carpenter" <dan.carpenter@...aro.org>,
 "Anders Roxell" <anders.roxell@...aro.org>, shuah <shuah@...nel.org>
Subject: Re: selftest/vDSO: vdso_test_abi tests with gcc-13 and pass with clang-19

On Wed, Feb 12, 2025, at 15:29, Naresh Kamboju wrote:
> The kselftest-vDSO/vdso_test_abi test encounters failures when built
> and executed using GCC-13 on armv7 architecture.
> The issue has been observed on both TI X15 devices and QEMU-armv7.
>
> Interestingly, the same test passes without any issues when built using
> Clang-19.This failure is specific to GCC-13. but test case should have
> been failed on clang toolchain but it did not.

To clarify: the failure depends on how the toolchain is built:
for compilers using the default 32-bit time_t in glibc, ltp does
not notice a problem, but using gcc it will run into a testcase
bug because the vdso_test_abi.c file incorrectly mixes libc types
and kernel types.

> The Clang toolchain likely defaults to the traditional 32-bit time_t on
> 32-bit Debian Trixie (except x86), leading to an ABI issue similar to
> older compilers. This is affecting compatibility.
>
> This is not a new regression,
> this report generated on Linux next but also seen on Linux stable tree.
>
> Test name: kselftest-vDSO/vdso_test_abi
> Fails: gcc-13
> pass: clang-19
>
> Arnd Bergmann investigated and proposed a patch which fixes the problem.

The patch only makes changes ltp so it tests the old system calls
correctly regardless of the toolchain settings.

Someone still needs to change LTP to include this change as well as
add tests for the 64-bit time_t vdso functions.

     Arnd