linux-kernel - Re: [PATCH v10 00/12] AMD broadcast TLB invalidation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6zMjTyqTihpl9BI@google.com>
Date: Wed, 12 Feb 2025 08:30:05 -0800
From: Sean Christopherson <seanjc@...gle.com>
To: Brendan Jackman <jackmanb@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Rik van Riel <riel@...riel.com>, x86@...nel.org, 
	linux-kernel@...r.kernel.org, bp@...en8.de, dave.hansen@...ux.intel.com, 
	zhengqi.arch@...edance.com, nadav.amit@...il.com, thomas.lendacky@....com, 
	kernel-team@...a.com, linux-mm@...ck.org, akpm@...ux-foundation.org, 
	jannh@...gle.com, mhklinux@...look.com, andrew.cooper3@...rix.com
Subject: Re: [PATCH v10 00/12] AMD broadcast TLB invalidation

On Wed, Feb 12, 2025, Brendan Jackman wrote:
> They apply to 60675d4ca1ef0 ("Merge branch 'linus' into x86/mm, to
> pick up fixes").
> 
> Rik, can I refer you to the BASE TREE INFORMATION section of man
> git-format-patch. I haven't used that feature lately (b4 takes care of
> this) but it looks like --base=auto will add the necessary info, or
> IIRC there's a way to make that behaviour the default.

IMO, --base=auto is too easy to unintentionally misuse, e.g. it will do the wrong
thing if your upstream branch is set to a personal repository.  --base itself is
fantastic though.  I personally do:

  git format-patch --base=HEAD~$nr <bunch of other stuff> -$nr

where $nr is the number of patches in the series.  I.e. advertise the base as
whatever the series of patches is based on, not what the branch is based on.  The
only time it doesn't work is if your local branch has a commit that is not in the
series, and is not publicly visible.  E.g. if the series depends on another in-flight
series that you've applied locally.  But in that case, you should be explaining
what's up in your cover letter no matter what.