linux-kernel - Re: [PATCH] mlxsw: Add return value check for mlxsw_sp_port_get_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wmdvcecg.fsf@nvidia.com>
Date: Wed, 12 Feb 2025 17:32:15 +0100
From: Petr Machata <petrm@...dia.com>
To: Wentao Liang <vulab@...as.ac.cn>
CC: <idosch@...dia.com>, <petrm@...dia.com>, <andrew+netdev@...n.ch>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH] mlxsw: Add return value check for
 mlxsw_sp_port_get_stats_raw()


Wentao Liang <vulab@...as.ac.cn> writes:

> Add a check for the return value of mlxsw_sp_port_get_stats_raw()
> in __mlxsw_sp_port_get_stats(). If mlxsw_sp_port_get_stats_raw()
> returns an error, exit the function to prevent further processing
> with potentially invalid data.
>
> Fixes: 614d509aa1e7 ("mlxsw: Move ethtool_ops to spectrum_ethtool.c")
> Cc: stable@...r.kernel.org # 5.9+
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>

Reviewed-by: Petr Machata <petrm@...dia.com>

Thanks!