linux-kernel - Re: [PATCH v1 1/2] power: ip5xxx_power: Make use of i2c_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <hnfdjznbvqbstcqd7rgrukqqdv7uasexojnujz63qgjnv7pja3@z4lanwhk4i6b>
Date: Wed, 12 Feb 2025 18:07:19 +0100
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Bence Csókás <csokas.bence@...lan.hu>, 
	Wolfram Sang <wsa+renesas@...g-engineering.com>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-pm@...r.kernel.org, Samuel Holland <samuel@...lland.org>
Subject: Re: [PATCH v1 1/2] power: ip5xxx_power: Make use of
 i2c_get_match_data()

Hi,

On Wed, Feb 12, 2025 at 06:46:23PM +0200, Andy Shevchenko wrote:
> Get matching data in one step by switching to use i2c_get_match_data().
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---

Acked-by: Sebastian Reichel <sebastian.reichel@...labora.com>

-- Sebastian

>  drivers/power/supply/ip5xxx_power.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/power/supply/ip5xxx_power.c b/drivers/power/supply/ip5xxx_power.c
> index c448e0ac0dfa..717ec86c769b 100644
> --- a/drivers/power/supply/ip5xxx_power.c
> +++ b/drivers/power/supply/ip5xxx_power.c
> @@ -828,7 +828,7 @@ static void ip5xxx_setup_regs(struct device *dev, struct ip5xxx *ip5xxx,
>  
>  static int ip5xxx_power_probe(struct i2c_client *client)
>  {
> -	const struct ip5xxx_regfield_config *fields = &ip51xx_fields;
> +	const struct ip5xxx_regfield_config *fields;
>  	struct power_supply_config psy_cfg = {};
>  	struct device *dev = &client->dev;
>  	const struct of_device_id *of_id;
> @@ -843,9 +843,7 @@ static int ip5xxx_power_probe(struct i2c_client *client)
>  	if (IS_ERR(ip5xxx->regmap))
>  		return PTR_ERR(ip5xxx->regmap);
>  
> -	of_id = i2c_of_match_device(dev->driver->of_match_table, client);
> -	if (of_id)
> -		fields = (const struct ip5xxx_regfield_config *)of_id->data;
> +	fields = i2c_get_match_data(client) ?: &ip51xx_fields;
>  	ip5xxx_setup_regs(dev, ip5xxx, fields);
>  
>  	psy_cfg.of_node = dev->of_node;
> -- 
> 2.45.1.3035.g276e886db78b
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)