linux-kernel - RE: [PATCH v1 8/8] i2c: rzv2m: Use i2c_10bit_addr_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYCPR01MB120933A95FDD284DD3BFF0E2FC2FC2@TYCPR01MB12093.jpnprd01.prod.outlook.com>
Date: Wed, 12 Feb 2025 17:08:14 +0000
From: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Andi Shyti
	<andi.shyti@...nel.org>, Wolfram Sang <wsa+renesas@...g-engineering.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>
CC: Krzysztof Adamski <krzysztof.adamski@...ia.com>, Florian Fainelli
	<florian.fainelli@...adcom.com>, Ray Jui <rjui@...adcom.com>, Scott Branden
	<sbranden@...adcom.com>, Broadcom internal kernel review list
	<bcm-kernel-feedback-list@...adcom.com>, Stefan Roese <sr@...x.de>, Matthias
 Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, Gregory CLEMENT
	<gregory.clement@...tlin.com>
Subject: RE: [PATCH v1 8/8] i2c: rzv2m: Use i2c_10bit_addr_from_msg() helper

> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: 12 February 2025 16:33
> Subject: [PATCH v1 8/8] i2c: rzv2m: Use i2c_10bit_addr_from_msg() helper
> 
> Use i2c_10bit_addr_from_msg() helper instead of local copy.
> No functional change intended.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>

> ---
>  drivers/i2c/busses/i2c-rzv2m.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-rzv2m.c b/drivers/i2c/busses/i2c-rzv2m.c
> index 02b76e24a476..55c5ce3b0f97 100644
> --- a/drivers/i2c/busses/i2c-rzv2m.c
> +++ b/drivers/i2c/busses/i2c-rzv2m.c
> @@ -287,13 +287,9 @@ static int rzv2m_i2c_send_address(struct rzv2m_i2c_priv *priv,
>  	int ret;
> 
>  	if (msg->flags & I2C_M_TEN) {
> -		/*
> -		 * 10-bit address
> -		 *   addr_1: 5'b11110 | addr[9:8] | (R/nW)
> -		 *   addr_2: addr[7:0]
> -		 */
> -		addr = 0xf0 | ((msg->addr & GENMASK(9, 8)) >> 7);
> -		addr |= !!(msg->flags & I2C_M_RD);
> +		/* 10-bit address */
> +		addr = i2c_10bit_addr_from_msg(msg);
> +
>  		/* Send 1st address(extend code) */
>  		ret = rzv2m_i2c_write_with_ack(priv, addr);
>  		if (ret)
> --
> 2.45.1.3035.g276e886db78b