linux-kernel - Re: [PATCH 1/2] media: dt-bindings: Add dt bindings for m2m-deinterlace device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e9432d7-0be1-4d98-9a61-cd288e53e772@kernel.org>
Date: Wed, 12 Feb 2025 18:22:00 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Matthew Majewski <mattwmajewski@...il.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Hans Verkuil <hverkuil@...all.nl>,
 "Dr. David Alan Gilbert" <linux@...blig.org>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Uwe Kleine-Konig <u.kleine-koenig@...libre.com>,
 Andrzej Pietrasiewicz <andrzejtp2010@...il.com>
Cc: devicetree@...r.kernel.org, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] media: dt-bindings: Add dt bindings for
 m2m-deinterlace device

On 12/02/2025 18:09, Matthew Majewski wrote:
> Create a new yaml schema file to describe the device tree bindings for
> the generic m2m-deinterlace driver.

Bindings are for hardware, not drivers, and usually not generic.

Please describe here exemplary devices.

> 
> Signed-off-by: Matthew Majewski <mattwmajewski@...il.com>
> ---
>  .../bindings/media/m2m-deinterlace.yaml       | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/m2m-deinterlace.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/m2m-deinterlace.yaml b/Documentation/devicetree/bindings/media/m2m-deinterlace.yaml
> new file mode 100644
> index 000000000000..3ac9c1e7be88
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/m2m-deinterlace.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/m2m-deinterlace.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: M2M Deinterlacer
> +
> +maintainers:
> + - Mauro Carvalho Chehab <mchehab@...nel.org>
> +
> +description: |
> +  A generic memory2memory device for deinterlacing video
> +  using dmaengine.

And what is this generic device supposed to do? What fits to generic device?

> +
> +properties:
> +  compatible:
> +    const: m2m-deinterlace
> +
> +  dma-names:
> +    items:
> +      - const: rxtx
> +
> +  dmas:
> +    items:
> +      - description: mem-to-mem capable DMA channel
> +
> +required:
> +  - compatible
> +  - dma-names
> +  - dmas
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    m2m-deinterlace {
> +        compatible = "m2m-deinterlace";
> +        dma-names = "rxtx";
> +        dmas = <&edma 20 0>;

This all looks rather like bindings for driver and not even quite
generic because looks quite simple. I guess media folks will provide
more input, but anyway it looks a bit not-DT-enough.

> +    };

Best regards,
Krzysztof