linux-kernel - Re: [PATCH 1/2] dt-bindings: hwmon: ir38060: Move & update dt binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250212-concierge-apricot-e5d3627afe93@spud>
Date: Wed, 12 Feb 2025 18:33:27 +0000
From: Conor Dooley <conor@...nel.org>
To: Rob Herring <robh@...nel.org>
Cc: Naresh Solanki <naresh.solanki@...ements.com>,
	Guenter Roeck <linux@...ck-us.net>, broonie@...nel.org,
	Jean Delvare <jdelvare@...e.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Patrick Rudolph <patrick.rudolph@...ements.com>,
	Andrew Jeffery <andrew@...econstruct.com.au>,
	linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: ir38060: Move & update dt binding

On Wed, Feb 12, 2025 at 11:57:13AM -0600, Rob Herring wrote:
> On Fri, Feb 07, 2025 at 06:58:03PM +0530, Naresh Solanki wrote:
> > Move dt binding under hwmon/pmbus & align accordingly.
> > 
> > Previously the DT binding was invalid & wouldn't work with pmbus driver.
> > Pmbus driver expects a regulator node & hence added the same.
> 
> 2 out of 3 (schema, dts, driver) agree. Fix the driver.
> 
> > 
> > Fixes: 1d333cd641fb ("ARM: dts: aspeed: sbp1: IBM sbp1 BMC board")
> > Signed-off-by: Naresh Solanki <naresh.solanki@...ements.com>
> > ---
> > Changes in V2:
> > 1. Update commit message
> > 2. Add Fixes tags
> > ---
> >  .../hwmon/pmbus/infineon,ir38060.yaml         | 61 +++++++++++++++++++
> >  .../bindings/regulator/infineon,ir38060.yaml  | 45 --------------
> >  2 files changed, 61 insertions(+), 45 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml
> > new file mode 100644
> > index 000000000000..e1f683846a54
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,ir38060.yaml
> > @@ -0,0 +1,61 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/pmbus/infineon,ir38060.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Infineon Buck Regulators with PMBUS interfaces
> > +
> > +maintainers:
> > +  - Not Me.
> 
> Nothing new here, but WTF. Expect a meta-schema change to warn on this.

And it was fucking me that did it, that's the best/worst part about it.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)