linux-kernel - Re: [PATCH v4 0/1] i2c: mediatek: add runtime PM operations and bus regulator control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <minka4xfg4pymy4hjekooqyqk6xpbgenacsw32u6pdf3llcyyl@eh4u4ohccx3d>
Date: Wed, 12 Feb 2025 19:37:08 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Zoie Lin <zoie.lin@...iatek.com>
Cc: Qii Wang <qii.wang@...iatek.com>, 
	Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Project_Global_Chrome_Upstream_Group@...iatek.com, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, teddy.chen@...iatek.com, 
	joseph-cc.chang@...iatek.com, leilk.liu@...iatek.com
Subject: Re: [PATCH v4 0/1] i2c: mediatek: add runtime PM operations and bus
 regulator control

Hi Zoie,

my comment was on the [PATCH v3 ...], this should have been
[PATCH v4 1/1]. If you use git-format-patch, most probably you
will get it right.

If you have more than one patch, you can use the --cover-letter.
option to get the patch 0/X.

On Tue, Feb 11, 2025 at 10:39:37PM +0800, Zoie Lin wrote:
> Introduce support for runtime PM operations in
> the I2C driver, enabling runtime suspend and resume functionality.
> 
> Although in most platforms, the bus power of i2c is always
> on, some platforms disable the i2c bus power in order to meet
> low power request.
> 
> This implementation includes bus regulator control to facilitate
> proper handling of the bus power based on platform requirements.
> 
> Signed-off-by: Zoie Lin <zoie.lin@...iatek.com>

Is it possible to have an ack from Qii?

> ---
>  drivers/i2c/busses/i2c-mt65xx.c | 73 +++++++++++++++++++++++++++------
>  1 file changed, 61 insertions(+), 12 deletions(-)
> 
> This series is based on linux-next, tag: next-20250210
> 
> Changes in v4:

what about the previous versions?

> - Removed unnecessary variable initialization.
> - Removed unnecessary brackets.
> - Corrected grammar issues in the commit message.
> - Confirmed autosuspend delay is not necessary.
> 

...

> @@ -1472,13 +1507,18 @@ static int mtk_i2c_probe(struct platform_device *pdev)
>  		}
>  	}
>  
> -	ret = clk_bulk_prepare_enable(I2C_MT65XX_CLK_MAX, i2c->clocks);
> +	ret = clk_bulk_prepare(I2C_MT65XX_CLK_MAX, i2c->clocks);
>  	if (ret) {
> -		dev_err(&pdev->dev, "clock enable failed!\n");

Why have you removed this dev_err? You coulde have rather changed
it to match the error. While at it you could also replace it with
dev_err_probe()

The rest looks good to me, I'll be happy if you can have an ack
from Qii.

Andi

>  		return ret;